Problem/Motivation

The "consent required" checkbox does absolutely when checked / unchecked on service entities created through submodules. This should be fixed!

Furthermore, we should add tests making sure the functionality stays.

Steps to reproduce

Proposed resolution

Intended "Consent Required" functionality:

Checked: Knockout the cookies generating element as long as no consent is given.

Unchecked: Consent is assumed, and the service isn't blocked.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork cookies-3323044

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Grevil created an issue. See original summary.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Category: Task » Feature request
grevil’s picture

grevil commented
Status: Active » Needs work

OK, the "Consent required" does absolutely nothing... Not good.

grevil’s picture

grevil commented
Title: Create tests for the Cooies service "Consent required" checkbox » Fix the Cookies service "Consent required" checkbox and add tests.
Issue summary: View changes
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: Unassigned » jfeltkamp

@Grevil: Half so wild (xD sorry for the poor joke) I think this just means, consent is always required technically. ;) But perhaps Joachim can tell us more about the background.

Grevil opened merge request !59

grevil’s picture

grevil commented

Rebased and opened the MR to see the failing test!

I am going to set this to minor, as implementing this will mostly do more harm than good. We definitely should let the user know, if updating to a version containing this change, that the consent required checkbox now has functionality and should be checked! As setting this checkbox incorrectly can lead to GDPR violations!

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Title: Fix the Cookies service "Consent required" checkbox and add tests. » Use the Cookies service "Consent required" value and add tests
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Parent issue: » #3323524: [META] Improve combination of COOKiES submodules and their services through "Drupal Plugins"
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Title: Use the Cookies service "Consent required" value and add tests » [2.x] Use the Cookies service "Consent required" value and add tests
Status: Needs work » Postponed

Postponing this on the parent issue for now, as we first need a clear high-level concept!

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Related issues: +#3268338: Set the default preference to 'allow' or 'deny' for each service
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Title: [2.x] Use the Cookies service "Consent required" value and add tests » [PP-2.x] Use the Cookies service "Consent required" value and add tests
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Version: 1.1.x-dev » 1.2.x-dev
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Title: [PP-2.x] Use the Cookies service "Consent required" value and add tests » [2.x] Use the Cookies service "Consent required" value and add tests
Version: 1.2.x-dev » 2.x-dev
Status: Postponed » Active

Hey ho, let's go! 2.x branch was recently created. Please help to implement this or if you're not a developer, please sponsor some development hours.