The CookieControl javascript is now at version 6.1. Several changes has been made to the javascript API that needs to be included in the CookieControl drupal module. I'm attaching the corresponding patch for review.

CommentFileSizeAuthor
#3 cookiecontrol-API-6_1-2112011-3.patch160.64 KBtim_dj
implements_6.1_jsAPI_changes-cookiecontrol.patch93.67 KBtper
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tper’s picture

tper CreditAttribution: tper commented
Assigned: tper » Unassigned
pjcdawkins’s picture

pjcdawkins CreditAttribution: pjcdawkins commented
Issue summary: View changes
Status: Needs review » Needs work

It's very hard to review the patch while the indentation is wrong - you have an indent of 4 spaces instead of 2. The patch is far bigger than it needs to be.

tim_dj’s picture

tim_dj
he/him
Location Netherlands
CreditAttribution: tim_dj commented
Status: Needs work » Needs review
FileSize
cookiecontrol-API-6_1-2112011-3.patch160.64 KB

While trying to implement and fix the above attached patch I found that on the website of CivicUK they actually provide an updated Drupal Module.

I've edited included that version in this patch with the following changes:
- 2 spaces instead of tabs
- removed trailing white spaces
- changed end of line for css from Windows to Unix

Be aware that this version of their API requires an free API key (depending on required functions)

budda’s picture

budda
Primary language English
Location Cheshire
CreditAttribution: budda at Ixis - UK Drupal Support, Maintenance, Hosting and Development commented

For reference the module using the v7 API is available from http://www.civicuk.com/cookie-control/downloads/drupal-module/cookiecont...