# Summary

A simple module that provides a block showing the current time.
Features

Time zone can be configured as: Site time zone, user time zone, local time zone and custom time zone.
Date format can be configured using the preconfigured "short", "medium" and "long" date types, as well as any custom date types.
The clock can be continuously updated via JavaScript

# Project URL

https://www.drupal.org/project/clock

# Where is the code?
https://www.drupal.org/sandbox/laxmang/2831894

# Estimated completion date
Dec 2016

# Dependencies

# Who's doing the port?
https://www.drupal.org/u/laxmanghavte

# What help do they need?

# D8 roadmap
Convert existing d7 module to d8

# Background and reference information

Comments

laxman.ghavte created an issue. See original summary.

laxman.ghavte’s picture

Assigned: laxman.ghavte » Unassigned
Status: Active » Needs review

Please review, Drupal 8 module code in sandbox
https://www.drupal.org/sandbox/laxmang/2831894

sourabh.singhal’s picture

Status: Needs review » Needs work

Hi laxman.ghavte,

There are some issues in your code which was detected on "https://pareview.sh" site. For your reference here is the URL for PA Review Code Result.

Thanks
Sourdrup

laxman.ghavte’s picture

Most code formatting issue is fixed. Please review.

laxman.ghavte’s picture

Status: Needs work » Needs review
sourabh.singhal’s picture

Hi Laxman,

Still showing some warnings. Please check

FILE: /root/repos/pareviewsh/pareview_temp/src/Plugin/Block/ClockBlock.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 7 WARNINGS AFFECTING 7 LINES
--------------------------------------------------------------------------
112 | WARNING | \Drupal calls should be avoided in classes, use
| | dependency injection instead
150 | WARNING | \Drupal calls should be avoided in classes, use
| | dependency injection instead
195 | WARNING | \Drupal calls should be avoided in classes, use
| | dependency injection instead
201 | WARNING | \Drupal calls should be avoided in classes, use
| | dependency injection instead
202 | WARNING | \Drupal calls should be avoided in classes, use
| | dependency injection instead
249 | WARNING | \Drupal calls should be avoided in classes, use
| | dependency injection instead
252 | WARNING | \Drupal calls should be avoided in classes, use
| | dependency injection instead
--------------------------------------------------------------------------

Thanks
Sourdrup

mmjvb’s picture

Status: Needs review » Needs work

With a dev release Status should be Needs work. Once tagged as alpha, beta, or rc it can be Needs review or RTBC.

Use the issue queue of the project itself for support issues. This issue is about the D8 port, see D8CPT description for usage of Status.

vipul tulse’s picture

Assigned: Unassigned » vipul tulse

Hello,

Can I fix those issue of \Drupal call avoided

vipul tulse’s picture

Assigned: vipul tulse » Unassigned
fdefeyter@gmail.com’s picture

I installed it but no block appears...

I finally put code in a block and it works.

But I can't get the current day...

fdefeyter@gmail.com’s picture

and put the timezone in htacess