Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I created a D8 port of this module for a recent project. I'd be happy to co-maintain the D8 version of this module if possible.
Comment | File | Size | Author |
---|---|---|---|
#10 | context_entity_field_8x_1x-2945487-10.patch | 36.73 KB | Etroid |
#4 | interdiff-2945487-2-4-do-not-test.diff | 4.2 KB | Daniel Korte |
#4 | context_entity_field_8x_1x-2945487-4.patch | 35.38 KB | Daniel Korte |
#2 | context_entity_field_8x_1x-2945487-2.patch | 35.59 KB | Daniel Korte |
Comments
Comment #2
Daniel KorteComment #3
clemens.tolboomI created a 8.x-1.x branch but are unable to release (no rights). But now you/we can at least use that branch though git.
Comment #4
Daniel KorteSome minor updates along with restricting the context entity field condition to the Context UI only. The reason for this is to avoid showing up in the Blocks UI and Layout Builder UI which causes issues on those pages. The solution for this was to use a hook function, but a solution that targets the Context UI itself would be better. However, this didn't seem possible since it appears that Context doesn't allow hook functions to alter condition definitions—at least from what I can tell.
Comment #5
c_archer CreditAttribution: c_archer as a volunteer and at Upbeat Productions commentedI've just tried the latest patch https://www.drupal.org/project/context_entity_field/issues/2945487#comme... and it seems to be working great for me.
Comment #6
Etroid CreditAttribution: Etroid commentedHey,
We are excited to use this module for D8 development. Daniel, have you reached out directly to the maintainers of this module?
Comment #7
Daniel KorteI just reached out to mavimo. In the meantime, if you or someone else could review the D8 patch that could speed things along if mavimo does not want another co-maintainer.
Comment #8
clemens.tolboom@Daniel Korte just to let you know: Through #2567481: Fix the testbot failures in 2015-10-17 I created a 8.x-1.x see https://cgit.drupalcode.org/context_entity_field/log/?h=8.x-1.x
Comment #9
Daniel Korte@clemens.tolboom Yup, that is one step closer. Thank you!
Comment #10
Etroid CreditAttribution: Etroid commentedTested the patch on my local and implementation works as advertised. I made a few changes to the code, but mostly for consistency and readability:
- Added help link
- Added suffix "Condition" to EntityFieldCondition class
- Added suffix "Deriver" to EntityFieldDeriver class
- Changed the order of arguments to the EntityFieldCondition constructor to be more consistent with its parent class
- Updated field label from "Field status" to "Field state"
- Updated Field state options to "Filled", "Empty" and "Value is"
Comment #11
Feng-Shui CreditAttribution: Feng-Shui commentedWe were using the above patch but started having issues with layout builder: https://www.drupal.org/node/2916876
We've switched to use this module, has a stable D8 release: https://www.drupal.org/project/entity_field_condition
Comment #12
clemens.tolboomI've added @Daniel Korte as a co-maintainer. Hope he finds time/budget to work on this longstanding issue
Comment #14
Daniel KorteThanks to @clemens.tolboom who just gave me maintainer permissions. I’m marking this as fixed with the commit I just made. Any new issues with the 8.x-1.x branch should be made in a new issue.
@Etroid Your patch does not apply to the repo. What did you use to make it? Please try again with the existing 8.x-1.x code and create a new issue. Thanks!
@Feng-Shui Please feel free to open a new issue with the problems you are having with the layout builder. Thanks!
Comment #15
Etroid CreditAttribution: Etroid commentedGreat news that a 8.x branch has finally been created. I'll create a follow-up issue for some of the code style issues.
Comment #16
clemens.tolboomCodestyle review #3073403: Code Style Issues