Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Daniel Korte created an issue. See original summary.

Daniel Korte’s picture

clemens.tolboom’s picture

I created a 8.x-1.x branch but are unable to release (no rights). But now you/we can at least use that branch though git.

Daniel Korte’s picture

Some minor updates along with restricting the context entity field condition to the Context UI only. The reason for this is to avoid showing up in the Blocks UI and Layout Builder UI which causes issues on those pages. The solution for this was to use a hook function, but a solution that targets the Context UI itself would be better. However, this didn't seem possible since it appears that Context doesn't allow hook functions to alter condition definitions—at least from what I can tell.

c_archer’s picture

I've just tried the latest patch https://www.drupal.org/project/context_entity_field/issues/2945487#comme... and it seems to be working great for me.

Etroid’s picture

Hey,

We are excited to use this module for D8 development. Daniel, have you reached out directly to the maintainers of this module?

Daniel Korte’s picture

I just reached out to mavimo. In the meantime, if you or someone else could review the D8 patch that could speed things along if mavimo does not want another co-maintainer.

clemens.tolboom’s picture

@Daniel Korte just to let you know: Through #2567481: Fix the testbot failures in 2015-10-17 I created a 8.x-1.x see https://cgit.drupalcode.org/context_entity_field/log/?h=8.x-1.x

Daniel Korte’s picture

@clemens.tolboom Yup, that is one step closer. Thank you!

Etroid’s picture

Tested the patch on my local and implementation works as advertised. I made a few changes to the code, but mostly for consistency and readability:

- Added help link
- Added suffix "Condition" to EntityFieldCondition class
- Added suffix "Deriver" to EntityFieldDeriver class
- Changed the order of arguments to the EntityFieldCondition constructor to be more consistent with its parent class
- Updated field label from "Field status" to "Field state"
- Updated Field state options to "Filled", "Empty" and "Value is"

Feng-Shui’s picture

We were using the above patch but started having issues with layout builder: https://www.drupal.org/node/2916876

We've switched to use this module, has a stable D8 release: https://www.drupal.org/project/entity_field_condition

clemens.tolboom’s picture

I've added @Daniel Korte as a co-maintainer. Hope he finds time/budget to work on this longstanding issue

Daniel Korte’s picture

Status: Needs review » Fixed

Thanks to @clemens.tolboom who just gave me maintainer permissions. I’m marking this as fixed with the commit I just made. Any new issues with the 8.x-1.x branch should be made in a new issue.

@Etroid Your patch does not apply to the repo. What did you use to make it? Please try again with the existing 8.x-1.x code and create a new issue. Thanks!

@Feng-Shui Please feel free to open a new issue with the problems you are having with the layout builder. Thanks!

Etroid’s picture

Great news that a 8.x branch has finally been created. I'll create a follow-up issue for some of the code style issues.

clemens.tolboom’s picture

Version: 7.x-1.x-dev » 8.x-1.x-dev

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.