$.browser is undefined for inline editor [#2734443]

When using the Context UI inline editor, JavaScript will generate errors if using jQuery 1.9 or greater. This is due to $.browser no longer being supported.

The better long term solution is to replace the code with feature detection rather than browser detection, but the attached patch should serve as a temporary replacement until that is done.

I'd appreciate any feedback, thanks.

Comment	File	Size	Author
#6	context-jquery_browser_undefined-2734443-6.patch	5.34 KB	ron_s
#6	7.x-3.x: PHP 5.3 & MySQL 5.5, D7 40 pass PHP 5.4 & MySQL 5.5, D7 40 pass PHP 5.5 & MySQL 5.5, D7 40 pass PHP 5.6 & MySQL 5.5, D7 40 pass
#6	interdiff-2734443-5-6.txt	1.28 KB	ron_s
#5	context-jquery_browser_undefined-2734443-5.patch	5.28 KB	ron_s
#5	7.x-3.x: PHP 5.3 & MySQL 5.5, D7 40 pass PHP 5.4 & MySQL 5.5, D7 40 pass PHP 5.5 & MySQL 5.5, D7 40 pass PHP 5.6 & MySQL 5.5, D7 40 pass
#5	interdiff-2734443-3-5.txt	2.02 KB	ron_s
#3	interdiff-2734443-1-3.txt	5.03 KB	ron_s
#3	context-jquery_browser_undefined-2734443-3.patch	5.25 KB	ron_s
#3	7.x-3.x: PHP 5.3 & MySQL 5.5, D7 40 pass PHP 5.4 & MySQL 5.5, D7 40 pass PHP 5.5 & MySQL 5.5, D7 40 pass PHP 5.6 & MySQL 5.5, D7 40 pass
	context-jquery_browser_undefined-1.patch	1.82 KB	ron_s

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

26 May 2016 at 16:27

ron_s created an issue. See original summary.

Comment #2

hass CreditAttribution: hass commented 26 May 2016 at 19:00

Status:

Needs review

» Needs work

Please rewrite to feature detection so we are finally done.

Comment #3

ron_s CreditAttribution: ron_s commented 2 June 2016 at 21:50

Status:

Needs work

» Needs review

File	Size
context-jquery_browser_undefined-2734443-3.patch	5.25 KB
7.x-3.x: PHP 5.3 & MySQL 5.5, D7 40 pass PHP 5.4 & MySQL 5.5, D7 40 pass PHP 5.5 & MySQL 5.5, D7 40 pass PHP 5.6 & MySQL 5.5, D7 40 pass
interdiff-2734443-1-3.txt	5.03 KB

1 file was hidden/shown/deleted

File	Size
context-jquery_browser_undefined-1.patch	1.82 KB

Ok, see attached patch.

The $.browser calls in editStart and editFinish must continue to stay in the code, because they are specific to a bug in jQuery UI 1.6.

We have moved them inside the conditional so they are never accessed if someone is running a newer version.

Comment #4

ron_s CreditAttribution: ron_s commented 3 June 2016 at 18:06

Status:

Needs review

» Needs work

After further testing, we realized some CSS adjustments are needed to support this approach. Will post an updated patch shortly.

Comment #5

ron_s CreditAttribution: ron_s commented 3 June 2016 at 19:12

Status:

Needs work

» Needs review

File	Size
interdiff-2734443-3-5.txt	2.02 KB
context-jquery_browser_undefined-2734443-5.patch	5.28 KB
7.x-3.x: PHP 5.3 & MySQL 5.5, D7 40 pass PHP 5.4 & MySQL 5.5, D7 40 pass PHP 5.5 & MySQL 5.5, D7 40 pass PHP 5.6 & MySQL 5.5, D7 40 pass

2 files were hidden/shown/deleted

File	Size
context-jquery_browser_undefined-2734443-3.patch	5.25 KB
7.x-3.x: PHP 5.3 & MySQL 5.5, D7 40 pass PHP 5.4 & MySQL 5.5, D7 40 pass PHP 5.5 & MySQL 5.5, D7 40 pass PHP 5.6 & MySQL 5.5, D7 40 pass
interdiff-2734443-1-3.txt	5.03 KB

This should take care of the issue. Just needed some extra CSS to ensure standard Drupal contextual links are still accessible.

Comment #6

ron_s CreditAttribution: ron_s commented 3 June 2016 at 19:31

File	Size
interdiff-2734443-5-6.txt	1.28 KB
context-jquery_browser_undefined-2734443-6.patch	5.34 KB
7.x-3.x: PHP 5.3 & MySQL 5.5, D7 40 pass PHP 5.4 & MySQL 5.5, D7 40 pass PHP 5.5 & MySQL 5.5, D7 40 pass PHP 5.6 & MySQL 5.5, D7 40 pass

2 files were hidden/shown/deleted

File	Size
interdiff-2734443-3-5.txt	2.02 KB
context-jquery_browser_undefined-2734443-5.patch	5.28 KB
7.x-3.x: PHP 5.3 & MySQL 5.5, D7 40 pass PHP 5.4 & MySQL 5.5, D7 40 pass PHP 5.5 & MySQL 5.5, D7 40 pass PHP 5.6 & MySQL 5.5, D7 40 pass

Sorry, one additional update. Forgot to copy over two edits to handle contextual links when a browser does not support the pointer-events feature. Thanks.