Support for existing views [#1583818]

This patch adds a new option 'Existing view' that allows you to choose which view you want to link to, it also rewrites the 'select content' operation to 'select view'

Comment	File	Size	Author
#4	i1583818-3.patch	4.35 KB	attiks
	content_menu_existing_view.patch	4.34 KB	attiks

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Simon Georges CreditAttribution: Simon Georges commented 15 February 2013 at 12:04

Patch still applies cleanly. Let's see if we commit it during the sprint.

Comment #2

danielnolde CreditAttribution: danielnolde commented 18 February 2013 at 22:03

Status:

Needs review

» Needs work

Nice thing to add, attik, and the patch still applies, but when i try to create a menu item for an "existing view", the next page gives me a PHP error:

Fatal error: Call to undefined function content_menu_menu_overview_form_submit_extended() in /Volumes/daten2/projekte/contentmenu/code/www/includes/form.inc on line 1464

As soon as the patch actually works, i'll commit it, since it's a good addition.

P.S..: Anyone interested in adding the same for an "existing panel"?

Comment #3

danielnolde CreditAttribution: danielnolde commented 19 February 2013 at 08:04

Status:

Needs work

» Fixed

The patch and the code worked (ignore the comment #2 above).
Had to fix some minor things (code style, checks for views/views_ui module and user permissions).

Committed to 7.1-1.x-dev (didn't make it in the 1.0 release, sorry) in fcfeda6702b483e19fbb38ea57e321897e360d20 and issue marked fixed.

Thoughts:
* Anyone interested in adding the same for an "existing panel"?
* We need a better architecture in menu_content to allow for a plugin system that makes the code for all those additions manageable in a clean and modular way. Any suggestions/ideas (=> new issue)