Problem/Motivation

On node edit forms with the Gin Admin theme the "Unlock" button is hidden behind a secondary actions dropdown button with the title "More actions". This became an issue after Gin admin theme introduced this dropdown menu, hiding all buttons except from the most important one ("Save" in case of a node).
I think "Unlock" button is too important to be hidden, as it should be used every time when user decides to not save the node. Having it hidden may cause increase number of content locked without valid reason.

Steps to reproduce

  1. Install and use as default admin theme the Gin Admin theme,
  2. Install "Content locking" module and enable this for one of the node types,
  3. Create or edit a node of type selected in previous point.
  4. Check that "Unlock" button is hidden behind a secondary actions dropdown button.

Proposed resolution

As it looks like Gin maintainers are not planning to change this feature (https://www.drupal.org/project/gin/issues/3466692), I think "Content locking" should takie similair approach like other modules, making their buttons to jump out of this dropdown menu. For example, like this: https://www.drupal.org/project/save_edit/issues/3461404

Issue fork content_lock-3473067

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

besek created an issue. See original summary.

astonvictor made their first commit to this issue’s fork.

astonvictor opened merge request !55

astonvictor’s picture

astonvictor commented
Version: 8.x-2.4 » 3.x-dev

thanks for the report

The simplest way is to add '#gin_action_item' => TRUE, to the unlock button. It won't break anything and won't require any update hooks to enable/disable smth.

FYI #gin_action_item was introduced in the 8.x-3.0-rc11 tag of the Gin theme (#3356717: Move Action buttons to sticky header).

astonvictor’s picture

astonvictor commented
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.