Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#20 3266071-drupal-10-compatibility-20.patch23.16 KBchr.fritsch
#18 tests_output.png555.65 KBJoel Guerreiro Borghi Filho

Issue fork content_lock-3266071

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

chr.fritsch created an issue. See original summary.

tmaiochi’s picture

tmaiochi commented
Assigned: Unassigned » tmaiochi

I'll work on this

tmaiochi’s picture

tmaiochi commented
Assigned: tmaiochi » Unassigned
Status: Active » Needs review

I just removed a deprecated code that was not updated yet. Kindly review it!

victoria-marina’s picture

victoria-marina commented
Assigned: Unassigned » victoria-marina

I'll review this.

victoria-marina’s picture

victoria-marina commented
Assigned: victoria-marina » Unassigned

I made some additions to this.

volkerk opened merge request !6

volkerk made their first commit to this issue’s fork.

volkerk’s picture

volkerk commented

beatrizramos made their first commit to this issue’s fork.

beatrizramos’s picture

beatrizramos commented
Status: Needs review » Needs work

I used drupal-check and found some problems:

  1. two deprecated functions: drupal_uninstall_schema() and drupal_install_schema().
  2. phpcs errors
alanmoreira’s picture

alanmoreira commented
Assigned: Unassigned » alanmoreira

I'll work on this.

alanmoreira’s picture

alanmoreira commented
Assigned: alanmoreira » Unassigned

Couldn't make much progress on this :/

alanmoreira’s picture

alanmoreira commented
Assigned: Unassigned » alanmoreira

Okay, had some insights and giving one more shot

alanmoreira’s picture

alanmoreira commented
Assigned: alanmoreira » Unassigned

I adjusted the tests that were not running because of the setUp function in the ContentLockTestTrait.php file.

However, there is still a test failing and I have not been able to identify the cause.

It is also necessary to open issues for compatibility with Drupal 10 in the modules that this module depends on: conflict and prefetch_cache.

I'm leaving the status as "Needs work"

Tauany Bueno’s picture

Tauany Bueno commented
Assigned: Unassigned » Tauany Bueno

hi, i'll work on this :)

Tauany Bueno’s picture

Tauany Bueno commented
Assigned: Tauany Bueno » Unassigned
Status: Needs work » Needs review

Hello!
I found one deprecated code in one of the tests and fixed it. Also, there was one phpcs error (Expected 1 space before "?"; 0 found) that I also fixed.
Regarding deprecated code, it seems like it was all fixed. I'm changing the status to needs review :)

Joel Guerreiro Borghi Filho’s picture

Joel Guerreiro Borghi Filho commented
Assigned: Unassigned » Joel Guerreiro Borghi Filho

Will review. =)

Joel Guerreiro Borghi Filho’s picture

Joel Guerreiro Borghi Filho commented
Assigned: Joel Guerreiro Borghi Filho » Unassigned
StatusFileSize
new tests_output.png555.65 KB

Reporting the functional tests outputs when running locally on branch 3266071-drupal-10-compatibility.

I did not get deprecated code notices, but as @tauany said, there are some phpcs fixes to be done.

Changing to RTBC, I hope everything is ok with this one.

Joel Guerreiro Borghi Filho’s picture

Joel Guerreiro Borghi Filho commented
Status: Needs review » Reviewed & tested by the community
chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
commented
StatusFileSize
new 3266071-drupal-10-compatibility-20.patch23.16 KB

Test with file. Not sure if drupalci.yml changes will be applied in MRs

  • chr.fritsch committed 82c2baf on 8.x-2.x authored by volkerk 
    Issue #3266071 by chr.fritsch, volkerk, alanmoreira, Tauany Bueno,...
chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed without the tests for prefetch_cache and conflict, because both modules are not D10 compatible.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.