Problem/Motivation

E.g. install the scheduled_transitions module and you'll see that the Unlock button is also shown on the "Scheduled transitions" tab.

Steps to reproduce

* Add scheduled_transitions and enable it
* Configure it to be used on a content type
* Go to a content item of that content type and open the scheduled transitions tab
* Check the buttons on the buttons on the page.

Proposed resolution

* Update the logic in \content_lock_form_alter to make sure it's only shown on the proper forms (now it checks the entity type and form type, but in some cases that's not enough).

Issue fork content_lock-3253358

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

daften created an issue. See original summary.

smustgrave’s picture

smustgrave commented
Version: 8.x-2.2 » 8.x-2.x-dev

Can confirm this issue on the latest 8.x-2.x branch

smustgrave opened merge request !32

smustgrave’s picture

smustgrave commented
Status: Active » Needs review

Could it be this simple?

smustgrave’s picture

smustgrave commented
Title: The button to unlock is shown in places it shouldn't be shown » [Maintainer signoff needed] The button to unlock is shown in places it shouldn't be shown
Status: Needs review » Needs work

And it wasn't haha

But there is a setting that you can disable what forms this shouldn't appear on. That also fixed the issue.

Need the maintainer to determine if this is a bug or not. Maybe the README (when added) can be expanded upon?

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Title: [Maintainer signoff needed] The button to unlock is shown in places it shouldn't be shown » The button to unlock is shown in places it shouldn't be shown
Category: Bug report » Task

Let's document how to exclude forms that you want to. I don't think we should be changing the current functionality.

smustgrave’s picture

smustgrave commented

When the README ticket lands can work on this one

smustgrave’s picture

smustgrave commented
Title: The button to unlock is shown in places it shouldn't be shown » Update README how to exclude forms

README landed.

smustgrave closed merge request !32

smustgrave opened merge request !39

smustgrave’s picture

smustgrave commented
Status: Needs work » Needs review

Updated README

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work
Issue tags: +Needs reroll

manish-31 made their first commit to this issue’s fork.

manish-31’s picture

manish-31 commented
Status: Needs work » Needs review

I have rebased the MR, needs review.

MR other updates include the reordering of sections, with the "Forms" section placed above "Recommendations" during conflict resolution, alongside the removal of an additional space from the "Table of Contents" section preceding the text "Forms".

  • alexpott committed d6898619 on 8.x-2.x authored by smustgrave 
    Issue #3253358 by smustgrave, manish-31, daften: Update README how to...
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.