Add new Bulk Action to Break Lock

Solution :

I added this feature to view content list, I think it works well.

Thank you, it's a very nice feature request.

When we do this, we should try to provide this action for every entity type that is using content lock.

I will try to cook something up.

Here it's implementation with a deriver.

I would like to here @kfritsche feedback on this, especially on the release part.

Lets give this another push.

Tests are passing. I think this is good to go.

Was reviewing it while it got committed :/

But still

1. +++ b/src/Plugin/Action/BreakLock.php
   @@ -0,0 +1,74 @@
   +    $this->lockService->release($entity->id(), $entity->language());
   

   Missing entity type id.

2. +++ b/src/Plugin/Action/BreakLock.php
   @@ -0,0 +1,74 @@
   +    return $object->access('update', $account, $return_as_object);
   

   Same issue as described in #2938092: Ajax lock not created due to strict permission checks, but would be fine for now.

3. +++ b/src/Plugin/Action/BreakLockDeriver.php
   @@ -0,0 +1,96 @@
   +  protected function getApplicableEntityTypes() {
   +    $entity_types = $this->entityTypeManager->getDefinitions();
   +    $entity_types = array_filter($entity_types, function (EntityTypeInterface $entity_type) {
   +      return $this->isApplicable($entity_type);
   +    });
   +
   +    return $entity_types;
   +  }
   ...
   +  protected function isApplicable(EntityTypeInterface $entity_type) {
   +    return $entity_type->entityClassImplements(ContentEntityInterface::class);
   +  }
   

   Not sure about this. Would it make sense to check configs here, if type is lockable?

General note regarding caching. I'm unsure about this, but maybe just to think about it. Are Actions cached? Views are cached could this run into problems?

Thanks for reviewing. I try to be more patient next time 😆

1. Nice find
3. I think thats fine. That doesn't mean that there are actions. That just means that these entity types could possibly used for the action.

The general problem is, that the view is most of the times cached. So the view says the entity is still locked, but it isn't. We have this problem with the "Break lock" operation as well. So thats not a problem of actions.

Fixed 1.