Update README For how to override strings

Not sure where should I post it, but when an admin unlocks content locked by others then two messages are shown:

The problem is that after the second message the first one isn't true anymore :). Probably the correct solution would be not to redirect the user to the form but to the view ..

Adding an update to fix a grammar issue. "Since" is for dates, not quantities of time. So you can say, "since Jan 1st", but not "since 33 seconds".

This lock is in place since @date

to

The content has been locked for @date

+++ b/src/ContentLock/ContentLock.php
@@ -555,7 +562,7 @@ class ContentLock extends ServiceProviderBase {
+          drupal_set_message($this->t('You can unlock it by clicking here: @link', ['@link' => $link]), 'warning');

Only this message is of type "warning" and all others of the type "status". Having two different types for two messages shown one after another leads to showing them in different message boxes - one for status messages and one for warning messages.

+++ b/src/ContentLock/ContentLock.php
@@ -555,7 +562,7 @@ class ContentLock extends ServiceProviderBase {
+          drupal_set_message($this->t('You can unlock it by clicking here: @link', ['@link' => $link]), 'warning');

Actually here we have to use the $type parameter provided to the method unlockStatusMessage, then it should be fine.

Adding messenger service to EntityBreakLockForm, since it's used in ContentLock, for consistency.

@honchov, I don't see ContentLock::unlockStatusMessage(). It must have been removed at some point.

It looks like some work needs to be done to fix the tests with this patch.

I started working on it, but it needs to be on Drupal 8.6, as some of the tests require it.

#3068618: I feel the message of unlocking is strange can be closed a duplicate

Closed #3068618: I feel the message of unlocking is strange as a duplicate of this.

Also closed #3214877: Altering timeout message

Also closed #3352197: Add option to change unlock button text

Added update to README will see if committer wants to update the defaults.

I think this is quite opinionated unless there's some UX study behind it which seems overkill?
Personally I think "Lock broken" is weird, "Unlocked" looks more user friendly to me, but I'm not a native English speaker.
I have not a very strong position on the other proposed changes.

Also liked Unlocked more personally, if that's the only change probably can make that. Just don't want to bikeshed for 6 years :)

Let's change "Lock broken" to "Unlocked" and be done.

Actually was only 2 spots.

Let's get this done.