content_lock new version cancel button does not work

Fixed on 6.x-2.x in 7443ee2, on 7.x-1.x fixed was merged in by f3bfe57. Fix will be in 6.x-2.8 and 7.x-1.3.

This bug was caused by overlooking one place where the security fix patch tried to check for the anti-CSRF token when it shouldn't be. The cancel button is implemented hackily, but through the form_api which is already itself protected against CSRF.

Thanks for the report!

Also doesn't work in 7.x-1.2

I'm currently having this problem with version 7.x-2.0. Clicking the Cancel button just refreshes the node edit page, every time. Did a recent update remove the fix that worked for 7.x-1.2?

Same with me, damonbla.

+1

+1

+1 For what it's worth, I'm using a Bootstrap sub-theme, and it appears that some Bootstrap js is being attached to the click event on the cancel button, and not a function from content_lock js.

Strange thing.
Originally Cancel button is put in $form[actions][cancel]. In that case, #validate parameter looks to be ignored and not fired.
When I moved button directly to $form[cancel], #validate function is fired and in general it works.

If you rename the button's label, for instance, from 'Cancel' to something else e.g. 'Cancel draft' the form is cancelled and you exit the draft.
For more information on this behaviour refer to - https://www.drupal.org/node/1342066

Here is a patch if for the 7.x-2.1 version of this module.

My mistake, the last patch I submitted changes too many of the cancel button entries.

All that needs to happen to get the 7.x-2.1 to work is make a slight change to line 556 of content_lock.module file.

Better/reworked patch attached.