Same as #2696593: Fix the module install during config import.

CommentFileSizeAuthor
#5 fix-the-module-install-2712671-5.patch3.95 KBFidelix
#4 fix-the-module-install-2712671-4.patch4.03 KBFidelix
#2 fix_the_module_install-2712671-2.patch1.28 KBjibran
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jibran created an issue. See original summary.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran at PreviousNext for University of Technology, Sydney commented
Status: Active » Needs review
FileSize
fix_the_module_install-2712671-2.patch1.28 KB
Fidelix’s picture

Fidelix CreditAttribution: Fidelix as a volunteer commented

This patch needs to be updated with the rest of #2696593: Fix the module install during config import

Fidelix’s picture

Fidelix CreditAttribution: Fidelix as a volunteer commented
FileSize
fix-the-module-install-2712671-4.patch4.03 KB

Here's an attempt to mimic the changes on file_browser.

Should be safer for new installations and config syncs

Fidelix’s picture

Fidelix CreditAttribution: Fidelix as a volunteer commented
FileSize
fix-the-module-install-2712671-5.patch3.95 KB

Fixed patch to not change file modes.

bjlewis2’s picture

bjlewis2 CreditAttribution: bjlewis2 at Modules Unraveled commented

OMG!!! This was driving me crazy for the better part of three days! But, patch #5 fixed config-import for me!

Thank you!

bjlewis2’s picture

bjlewis2 CreditAttribution: bjlewis2 at Modules Unraveled commented

Just curious if this has anything to do with this core but that's fixed in 8.1.4: https://www.drupal.org/node/2754477

Fidelix’s picture

Fidelix CreditAttribution: Fidelix as a volunteer commented

Apparently the module author refactored the module and this might or might not be necessary anymore.
He did not pay attention to this issue, but there is a little bit of code that addresses configSync.

We need someone to test - unfortunately I do not have the time at the moment.

samuel.mortenson’s picture

samuel.mortenson
he/him
Primary language English
CreditAttribution: samuel.mortenson at Acquia commented
Status: Needs review » Fixed

@fidelix

He did not pay attention to this issue, but there is a little bit of code that addresses configSync.

That's not completely accurate. ;) I knew that I wanted to refactor Content Browser and didn't want to work on any issues that may become outdated after that work was complete. File Browser has also seen a huge boom in adoption so it has been taking up a lot of my time.

Committed the patch here after removing DOS-style line endings added after @jibran's initial patch.

Fidelix’s picture

Fidelix CreditAttribution: Fidelix as a volunteer commented

Fantastic. Thank you very much @samuel.mortenson

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.