FILE: D:\xampp\htdocs\drupal_10\web\modules\contrib\content_access\src\Form\ContentAccessAdminSettingsForm.php
--------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------
124 | WARNING | Role::loadMultiple calls should be avoided in classes, use dependency injection instead
--------------------------------------------------------------------------------------------------------------

CommentFileSizeAuthor
#3 3368271 - after patch.png127.56 KBkenyoowen
#3 3368271 - applied patch.png113.65 KBkenyoowen
#3 3368271 - before patch.png111.27 KBkenyoowen
#2 3368271-2.patch2.53 KBarti_parmar

Issue fork content_access-3368271

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

arti_parmar created an issue. See original summary.

arti_parmar’s picture

arti_parmar commented
Assigned: arti_parmar » Unassigned
Category: Task » Bug report
Status: Active » Needs review
StatusFileSize
new 3368271-2.patch2.53 KB

Kindly review patch.

kenyoowen’s picture

kenyoowen commented
Status: Needs review » Needs work
StatusFileSize
new 3368271 - before patch.png111.27 KB
new 3368271 - applied patch.png113.65 KB
new 3368271 - after patch.png127.56 KB

Hi arti_parmar

I applied your patch and confirmed that the phpcs issue mentioned is resolved, but it added issues which is:

FILE: /Users/studenttrainees/Project10/drupalorg10/docroot/modules/contrib/content_access/src/Form/ContentAccessAdminSettingsForm.php
---------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------------------------------------------------
48 | ERROR | [x] Expected 1 space after asterisk; 2 found
134 | ERROR | [x] Expected 1 space after "="; 2 found
--------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------

Please see the screenshots attached.

Thank you.

elber made their first commit to this issue’s fork.

elber’s picture

elber
Primary language Portuguese, Brazil
Location Brazil
commented
Status: Needs work » Needs review

I fixed the phpcs

elber opened merge request !8

  • arti_parmar authored f0527791 on 2.0.x 
    Issue #3368271 by arti_parmar, elber, kenyoOwen, gisle: Role::...
gisle’s picture

gisle
he/him
Primary language Norwegian Bokmål
Location Norway
commented
Status: Needs review » Fixed

This has been committed to the latest snapshot of 2.0.x-dev.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.