This project is currently not being tested against Drupal 9, is not being tested with MySql 8, is not being tested with PHP 7.4, and is not being tested with PHP 8.0. Each of those has breaking changes that could cause this module to fail with those configurations.

It is important to test against these, and to have a periodic test (run weekly perhaps) to test against the latest development version of core, so that we can see in advance any problems caused by recent changes in core.

This is a test issue with a dummy patch, just so I can run tests with various configurations to see what the results are.

CommentFileSizeAuthor
test-only.patch180 bytestr

Issue fork content_access-3226569

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

TR created an issue. See original summary.

tr’s picture

tr commented
Issue summary: View changes
tr’s picture

tr commented

The PHP 7.2 & MySQL 8, D9.2 test failed because Drupal 9.2 requires a minimum PHP version of 7.3.

But all the other configurations worked, which is great news!

I suggest that the automated test configurations at https://www.drupal.org/node/144819/qa be edited by the project manager to add some of these tests and to add at least one weekly test so that we can make sure this module continues to function on the more up-to-date versions of Drupal core, PHP, and MySql.

gisle’s picture

gisle
he/him
Primary language Norwegian Bokmål
Location Norway
commented
Version: 8.x-1.x-dev » 2.0.x-dev

This should go into the the most recent branch.

steven jones’s picture

steven jones commented
Status: Needs review » Active

We probably need to re-think about what configurations we want, and even if we want a matrix of configurations.

I've left a todo in our config, because at the moment, we're having to test with Drupal 9 instead of 10 because the ACL module isn't available for Drupal 10.
I wonder if we should keep with Drupal 9 for now, and try to get a Drupal 10 version of ACL completed, and then we can jump to testing with only Drupal 10. That might be a better use of everyone's time and effort?

gisle’s picture

gisle
he/him
Primary language Norwegian Bokmål
Location Norway
commented

There is a dev-release of ACL that is compatible with Drupal 10: https://www.drupal.org/project/acl/releases/2.x-dev.

We should be able to test against that.

steven jones’s picture

steven jones commented
Assigned: Unassigned » steven jones

Ahah, let me try that, one moment.

steven jones’s picture

steven jones commented

Going to make an issue fork for this issue, and work on it in there.

Steven Jones opened merge request !10

  • Steven Jones committed 8c4d5ee3 on 2.0.x 
    Issue #3226569 by Steven Jones: See if we can allow version 2.x of ACL.
steven jones’s picture

steven jones commented
Assigned: steven jones » gisle

Okay, that worked, so we now test against Drupal 10 using Gitlab CI.

@gisle we could probably disable the Drupal CI stuff now, and then mark this issue closed?

gisle’s picture

gisle
he/him
Primary language Norwegian Bokmål
Location Norway
commented
Status: Active » Fixed

I've verified that the Drupal CI also passed with MySQL 8, PHP 8.1 and Drupal 10.

I've disabled the automated Drupal CI tests, we will rely on Gitlab CI. in the future. Gitlab CI will not test against patches, but it shall be trivial to convert patches to MRs if users submit patches.

Thank you, both TR and Steven Jones, for great work on getting an fixed and improved CI test fraework in place.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.