Content Access Drupal 8 port

Hey Lachlan. Have you started work on porting this module to D8?

Hi. I have competed port of Content Access to Drupal 8 (beta10).
Can you review it?

Main part of module's functionality works good, however there are some things to work on.
TODOs:

1. Implement ACL integration
   need to wait for ACL Drupal 8 release
2. Implement Rules integration
   need to wait for Drupal 8 alpha or beta release, currently it is too unstable
3. check and complete automated tests

Also I see that you are searching for co-maintainers. Can I help you with that?

I have fixed config settings schema and completed automated testing code porting.
Will be happy if you review my new patch

I'll track ACL and Rules D8 version development state, and integrate Content Access with them as soon as possible

I have ported ACL module to Drupal 8 (https://www.drupal.org/node/2495027) and integrated Content Access with ACL.
Please review updated patch.

Tests won't pass because issue version is 7.x

Thanks, elachlan!

Patch tested with Drupal 8 beta 11, works correctly

Thanks!,Quick nitpicks

+++ b/content_access.install
@@ -5,13 +5,38 @@
+  $config = \Drupal::configFactory()->getEditable('content_access.settings');
+  $node_types = node_type_get_names();
+  $node_types_names = array_keys($node_types);
+  foreach ($node_types_names as $name) {
+    $config->delete('content_access_' . $name);
   }
+  $config->delete('content_access_roles_gids');
+  $config->save();

Configuration automatically deletes when the extension(module,theme) uninstalled.

Thanks, Naveen!
Updated patch

@fago,
Pushed changes to 8.x-1.x
Please review them and change this branch to dev branch if it works for you

Hi id.tarzanych :) Thanks for your contributions

Hi all :) I searched for a Drupal 8 branch but found nothing. Is it normal? Search result at https://www.drupal.org/node/144819/release?api_version[]=7234

Set Status to "Needs work". As I'm assuming the Drupal 8 branch is not yet created. Any volunteer to create that branch?

After a Drupal 8 branch is available. We would be happy to contribute testing patch, quality assurance, documentation, and agile project management services if needed

Related pages

• Drupal 8.0.0 will be released on November 19, 2015
• News about "Porting modules and themes to Drupal 8 "
• "Drupal Module Upgrader" module. Which can do some of this automatically for you, covering many API hooks.
• Documentation about "Converting 7.x modules to 8.x"

got a trouble to enable patch testing for 8.x branch for #2655796: Implement Content Access manager service

Is there a roadmap for an alpha or beta release?
Is there any major task preventing a release? What can be done to help?

any update on this? I checked out the git repo and see no 8.x tags.

right, okay. Thanks for the clarification @elachlan, I am not seeing the 8.x-1.x branch. As I poke around online, I'm seeing reports that the dev branch does indeed work, more or less, right now. Is there a ticket outlining the path to beta/alpha/rc/release? It would be nice to get a sense of how many issues are blocking the progression to an official/stable release.

How to migrate to 8.x from 7.x?
Thanks.

for those looking for quick alternatives, the Page Access module is simple and promising:

https://www.drupal.org/project/page_access

It is still in need of some basic functionality, which has been submitted via patch:

https://www.drupal.org/node/2849297#comment-11922102
https://www.drupal.org/node/2813571#comment-11932798

Hopefully Page Access and/or the ported Content Access modules will mature soon, as they provide crucial functionality.

I do not want to create new site. I have to migrate existing content, existing nodes with permissions attached to each of these nodes.

About comment #31:

Please don't use the page_access module. It has a bad security issue, and the module authors absolutely do not care:

https://security.drupal.org/node/161758

This security issue, which lets you view the content of pages even if you are not supposed to be allowed to access them, has been ignored, despite the authors are aware of the issue (they commented in the bug report).

Content Access works like a charm, even if it's not even an alpha.

Huh, well thanks for that info @LpSolit!!! I was unaware.

@LpSolit, I've noticed a few things. One is that I cannot access the resource you linked. It appears to be restricted to users with a higher privilege than I have. I also don't see any security issues filed on the Page Access module page. It's not that I don't believe you, but if PA needs to make improvements, how can they know to do so if security issues aren't published on the project? Or are security issues handled separately via the resource you linked to prevent public disclosure until they are fixed? Apologies for my ignorance, I'm not familiar with all of the ins and outs of how d.org works.

The other thing I noticed is that PA has been given the blessing by the Drupal Security Team. CA, on the other hand, despite having a long history and widespread use, has not. There's a concerning warning on the CA module home page that:

This project is not covered by the security advisory policy.
Use at your own risk! It may have publicly disclosed vulnerabilities.

I trust your warning about PA, but I'm trying to make sense of that comment in the context of the above warning on CA. I opened an issue to address CA's security warning, but if you are familiar with the security aspects of CA and/or PA, could you (or anyone else who is) kindly shed some more light on this?

Hello xeM8VfDh,

Security issues are indeed handled separately (in security.drupal.org instead of www.drupal.org) to avoid disclosing vulnerabilities before they are patched. The Page Access maintainers have been added to the bug report so that they can access it. And as I said in my previous comment, they are aware of the issue since mid-December (they replied in the bug report one week after the issue has been reported), so they have all the necessary information to fix the issue. But they didn't do any work on the issue.

The reason their module is marked as covered by the security advisory policy is because the maintainers of the Page Access module marked their module as stable. When a maintainer leaves his module in the dev, alpha or beta state, the comment about the security advisory policy says that the module is not covered by the policy. This doesn't mean the module is not secure or less secure than a module marked as stable (as it's only based on the opinion of the maintainer of the module).

But we are a bit off-topic... You can contact me privately, if you want, so that comments here remain focused on the Content Access module and its port to Drupal 8. :)

@LpSolit, thank you VERY much for the thorough info! I'll contact you privately if I have any more related questions, but you gave me exactly what I was looking for! Thanks again.

Do we have any road map to complete the port?

@johndevman, the port seems pretty stable and robust in my testing. I'm wondering what the roadmap for beta/alpha/rc/prod releases is. Also, interested in the security review. It seems everything is very close, but I am not sure if the developers responsible for D8 branch are still looking at this project and its issues queue.

@MStrzelecki_: For migrate support see issue: #2880499: Add migrate support

I did not have much time for maintaining the project during the last years and unfortunately id.tarzanych seems inactive as well. Anyone who would like to step up and help maintaining would be welcome! Please contact me via my contact form if you are up for getting involved!

I've just went through the queue and looked at all RTBC issues + tagged a first alpha as the port is basically workign.

thanks for the update @fago, hopefully someone will step in... its an awesome module that has lots more life in it, I think.

Imo we should focus on getting test coverage and converting the simple tests to phpunits. Perhaps a suggested road map would be a good start?

This issue has not received any updates in the previous 2 years. If you believe it to still be relevant, you are encouraged to reopen the issue and update it.

If you got an email about this Issue status update, it is because you at one time (possibly a very long time ago), subscribed to it. To learn how to unsubscribe yourself, please visit: https://www.drupal.org/project/webmasters/issues/3142987