Problem/Motivation

The body field on the base entity table has a serialised array of value & format stored in a string long field. It has been pointed out that a text_long would be the appropriate type for this (credit @Berdir - thank you!). Without this change it can cause issues for those using the rest API for instance.

Proposed resolution

Create new base storage definition and migrate content from the old to the new then discard the old.

Remaining tasks

Test.

User interface changes

Minor label tweaks.

API changes

Anyone using the 'body' value directly modifying the module will need to use 'message' instead. No methods or functions are changing.

Data model changes

New field 'message' to replace 'body.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

scott_euser created an issue. See original summary.

scott_euser’s picture

Status: Active » Needs review
FileSize
18.06 KB

First attempt. Needs update tests still, but setting to needs review to trigger tests.

scott_euser’s picture

Status: Needs review » Needs work
scott_euser’s picture

Status: Needs work » Needs review
FileSize
18.34 KB
0 bytes

Refreshed previous update test.

Status: Needs review » Needs work

The last submitted patch, 4: convert_body_to_use-2886020-4.patch, failed testing. View results

scott_euser’s picture

Status: Needs work » Needs review
FileSize
0 bytes

And with binary change in the patch....

Status: Needs review » Needs work

The last submitted patch, 6: convert_body_to_use-2886020-6.patch, failed testing. View results

scott_euser’s picture

Status: Needs work » Needs review
FileSize
333.56 KB

Attempting again to add binary to patch.

Status: Needs review » Needs work

The last submitted patch, 8: convert_body_to_use-2886020-8.patch, failed testing. View results

scott_euser’s picture

Status: Needs work » Needs review
FileSize
442.32 KB

Status: Needs review » Needs work

The last submitted patch, 10: convert_body_to_use-2886020-10.patch, failed testing. View results

scott_euser’s picture

Doh, database dump is drupal core 8.3, will attempt again

scott_euser’s picture

Failure to update to 8.4 appears to be a result of https://www.drupal.org/node/2874827

scott_euser’s picture

Status: Needs work » Postponed

Can update the update tests to use 8.4x until the following are solved:

https://www.drupal.org/node/2882456
https://www.drupal.org/node/2874827

And the tests run against 8.4x

scott_euser’s picture

Status: Postponed » Needs review

Given up for now, testing against d8 stable instead.

scott_euser’s picture

scott_euser’s picture

Status: Needs review » Fixed
scott_euser’s picture

Status: Fixed » Closed (fixed)