Problem/Motivation

EntityConflictResolutionEvent::createFromConflictDiscoveryEvent some parameter passed to the static functions are undefined.

EntityConflictResolutionEvent.php#L55, notice the $event->LocalEntity or `$event->RemoteEntity The variable are actually called ‘localEntity’ and ‘remoteEntity’ in the class EntityConflictDiscoveryEvent.php

Solution

Fix it with the correct variable.

CommentFileSizeAuthor
#2 3299773-2.patch1.25 KBLal_

Issue fork conflict-3299773

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Lal_ created an issue. See original summary.

Lal_’s picture

Issue summary: View changes
StatusFileSize
new1.25 KB
Lal_’s picture

Status: Active » Needs review
mpaulo’s picture

Assigned: Unassigned » mpaulo

Reviewing this.

mpaulo’s picture

Assigned: mpaulo » Unassigned
Status: Needs review » Needs work

@Lal_, wouldn't using the static return type make it impossible for the module to be compatible with PHP < 8?
Was it intended? If so, you can move it back to NR.

narendra.rajwar27’s picture

.