Updated: Comment #N

Problem/Motivation

We need people to look at the whole config translation module. When they do, we should discuss and deal with what they identify. :)

Proposed resolution

Address their feedback.

Also, if there are a group of things that fit under a topic, we can make sub issues for them. We should then link those here so we can track them and not lose track of any concerns.

Remaining tasks

Get the patch from the drupal issue.

User interface changes

API changes

#1952394-126: Add configuration translation user interface module in core

Similar what we did for #2114439: Fixes for the big larowlan review.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tim.plunkett’s picture

Status: Active » Needs review
FileSize
16.34 KB
54.34 KB

The patch includes my fixes in #1952394-126: Add configuration translation user interface module in core, and fixes for @dawehner's comments.
The interdiff is just those new fixes.
I also fixed the bundle problem I mentioned, but it still needs tests.

Status: Needs review » Needs work

The last submitted patch, ct-2123575-1.patch, failed testing.

tim.plunkett’s picture

Gábor Hojtsy’s picture

Assigned: Unassigned » Gábor Hojtsy

@tim.plunkett: first of all *huge* thanks for this review and for delivering it in a patch form. Amazing!

Second, I'm not sure what you mean in #3, but looks like #2098089: Date formats cannot be translated (the core UIs are useless) introduced the fails in this patch (but in a good way :D). It moved the language context to the global config contexts, so we need to just use it from the new place. (There may be other fails, but as with a module trying to follow how core changes, sometimes the code is just failing under us without this module changing a bit :D) I'm looking into fixing that fail right now.

Gábor Hojtsy’s picture

Status: Needs work » Needs review
FileSize
899 bytes
57.95 KB

Let's see how fixing the context will affect our fails :)

Status: Needs review » Needs work

The last submitted patch, ct-2123575-5.patch, failed testing.

Gábor Hojtsy’s picture

Status: Needs work » Needs review
FileSize
58.51 KB

It helps if i actually include the change in the patch :D Same as #5 should have been.

Gábor Hojtsy’s picture

Status: Needs review » Active

Committed #7. We can either continue fixing / improving here to in separate issues. @timplunkett: we also have #2117711: Add tests to date format translation UI for test coverage for the newly added date type in core following #2098089: Date formats cannot be translated (the core UIs are useless).

Gábor Hojtsy’s picture

Status: Active » Needs review
FileSize
12.83 KB

Addressing #1952394-125: Add configuration translation user interface module in core points 2/3 by moving the entity discovery into the info hook instead of the plugin manager. This also let us remove 3 injected services from the plugin manager. :) This makes the manager work clearly on the meta level only while discovery happens with the .yml and info hooks only and not directly in the manager. Looking forward to what the testbot says :D

Status: Needs review » Needs work

The last submitted patch, manager-to-info-hook.patch, failed testing.

Gábor Hojtsy’s picture

Status: Needs work » Needs review
FileSize
1.19 KB
0 bytes

Now need to mock the module list and theme list stuff, since its in the constructor. Only the unit tests fail for that.

Gábor Hojtsy’s picture

FileSize
13.31 KB

Meh.

Status: Needs review » Needs work

The last submitted patch, manager-to-info-hook-2.patch, failed testing.

Gábor Hojtsy’s picture

Status: Needs work » Needs review
FileSize
1.43 KB
13.2 KB

Trying to mock list_themes() is pointless obviously since its a global function from theme.inc that is already defined :/ So we can disable looking at themes for now to continue with this patch. You'll notice this will pass because we are not actually testing that a theme could provide a .yml file. Yeah, needs to be fixed.

Gábor Hojtsy’s picture

Now updated with fixes for the remaining points in #1952394-125: Add configuration translation user interface module in core. See also #1952394-132: Add configuration translation user interface module in core for detailed explanation on the createInstance() change.

Gábor Hojtsy’s picture

Status: Needs review » Fixed

Committed #15.

Gábor Hojtsy’s picture

Opened #2123897: Restore theme .yml support, add/fix tests for theme .yml testing and restoring that stuff.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.