Add missing tests for config_translation.mapper_list and config_translation.entity_list [#2098675]

Comment	File	Size	Author
#7	config-translation-ui-tests-2098675-7.patch	4.71 KB	webflo

#7	config-translation-ui-tests-2098675-3-7.interdiff.txt	3.75 KB	webflo
#3	config-translation-ui-tests-2098675-3.patch	4.44 KB	webflo

#1	config-translation-ui-tests-2098675-1.patch	3.98 KB	webflo

Comment #1

webflo CreditAttribution: webflo commented 26 September 2013 at 15:39

Status:

Active

» Needs review

File	Size
config-translation-ui-tests-2098675-1.patch	3.98 KB

This patch depends on #2098661: Provide config schema for Config test entity

Log in or register to post comments

Comment #2

26 September 2013 at 15:51

Status:

Needs review

» Needs work

The last submitted patch, config-translation-ui-tests-2098675-1.patch, failed testing.

Log in or register to post comments

Comment #3

webflo CreditAttribution: webflo commented 27 September 2013 at 09:08

Status:

Needs work

» Needs review

File	Size
config-translation-ui-tests-2098675-3.patch	4.44 KB

Log in or register to post comments

Comment #4

27 September 2013 at 09:23

Status:

Needs review

» Needs work

The last submitted patch, config-translation-ui-tests-2098675-3.patch, failed testing.

Log in or register to post comments

Comment #5

webflo CreditAttribution: webflo commented 27 September 2013 at 22:14

Status:

Needs work

» Needs review

#3: config-translation-ui-tests-2098675-3.patch queued for re-testing.

Log in or register to post comments

Comment #6

Gábor Hojtsy

he/him

Hungarian

Hungary

CreditAttribution: Gábor Hojtsy commented 27 September 2013 at 22:37

Status:

Needs review

» Needs work

+++ b/lib/Drupal/config_translation/Tests/ConfigTranslationOverviewTest.php
@@ -0,0 +1,97 @@
+      'name' => 'Configuration Translation',
+      'description' => 'Translate settings and entities to various languages',
+      'group' => 'Configuration Translation',

Name should have "overview at the end" IMHO.

Also should description have a dot?

+++ b/lib/Drupal/config_translation/Tests/ConfigTranslationOverviewTest.php
@@ -0,0 +1,97 @@
+    $this->assertText(format_string('Translations for @label @type', array('@label' => $test_entity->label(), '@type' => Unicode::strtolower($entity_info['label']))));

assert()s should still use t() for the text, like the line below. So construct the string the same way with t() as in the code here.

+++ b/tests/config_translation_test/config_translation_test.info.yml
@@ -0,0 +1,8 @@
+name: 'Configuration Translation test module'

+++ b/tests/config_translation_test/config_translation_test.module
@@ -0,0 +1,17 @@
+ * Configuration Translation test module.

Test Module