Autogenerate config entity translation mapping as much as is sane

Glad to see a start here. I was thinking of trying to get something here to show that #2085907: Ensure all configuration entities have an Edit/Configure tab by default would work now that #1834002: Configuration delete operations are all over the place is in.

Here's a straight re-roll for startes as the drupalPostForm() patch was committed. This will not pass, but then I can provide an interdiff on top of this.

I hope this passes...

Here we go. The previous patch failed because I passed the entity manager into the constructor at the wrong spot.

Also I added a typehint for $entity_manager in ConfigEntityMapper::__construct() after creating the interdiff(s) and couldn't be bothered to roll new ones. I promise that's the only thing I changed outside of the interdiff(s).

Because I had to change the indentation of a whole chunk of code I also provided an interdiff with the "no-whistespace" option of Git.

This should be close to done, I hope.

Fixed #18.

Also: Really, Drupal?!? language_manager, but entity.manager? ...

Pretty please, little bot?!

/me no like empty patch

(interdiff should be correct, though)

Straight re-roll. Not testing yet, as it will fail in the same way as before.

1. +++ b/config_translation.services.yml
   @@ -10,4 +10,9 @@ services:
   +    arguments:
   +      - '@cache.cache'
   +      - '@language_manager'
   +      - '@module_handler'
   +      - '@entity.manager'
   +      - '@string_translation'
   

   OOOOH, this is nice!

2. +++ b/lib/Drupal/config_translation/ConfigMapperManager.php
   @@ -50,31 +73,50 @@ class ConfigMapperManager extends DefaultPluginManager {
   +        $this->t('@label @entity_type', array('@entity_type' => Unicode::strtolower($entity_type))),
   

   Oh @label is not replaced on here?

Here we go. *crossingfingers*

Self-review of the interdiff:

1. +++ b/lib/Drupal/config_translation/ConfigEntityMapper.php
   @@ -55,10 +57,12 @@ class ConfigEntityMapper extends ConfigNamesMapper {
   -  public function __construct($base_path_pattern, $title, EntityManager $entity_manager, $names = array(), $menu_item_type = MENU_LOCAL_TASK, $add_edit_tab = FALSE) {
   +  public function __construct($base_path_pattern, $title, $id, EntityManager $entity_manager, $names = array(), $menu_item_type = MENU_LOCAL_TASK, $add_edit_tab = FALSE) {
   

   This should actually been part of the re-roll above, but I missed it there.

2. +++ b/lib/Drupal/config_translation/ConfigMapperManager.php
   @@ -77,12 +77,14 @@ class ConfigMapperManager extends DefaultPluginManager {
   +        !in_array('\Drupal\Core\Config\Entity\ConfigEntityInterface', class_implements($entity_info['class'])) ||
   

   Yeah, this part is pretty important... *slapsforehead*

OMFG, the constructor change took an infinite amount to figure out. I need more sleep...

#33: 2085925-config-trans-dx-32.patch queued for re-testing.

Here we go. This fixes one issue and also introduces some debug code for the bot in case this still fails.

I rerolled this for the latest commits.

If this passes, I owe @vijaycs85 a very large amount of tea/beer/...

Thanks @GáborHojtsy for helping with the actual fail.

Here we go. SimpleTest decided to work again on my laptop, so I hope I won't have to spam this issue as much. At least one test case passes with this, let's see...

So this passes completely on my system.

Awesome! See you in #2095837: Automatically discover mappers from config forms