Follow up of #2031185: Create configuration schema for language config entity which is a follow up of #1754246: Languages should be configuration entities

CommentFileSizeAuthor
#11 2031207-language-entity-group-11.patch2.57 KBGábor Hojtsy
#9 2031207-language-entity-group-9.patch2.22 KBGábor Hojtsy
#7 2031207-language-entity-group-7.patch2.21 KBGábor Hojtsy
#5 2031207-language-entity-group-5.patch1.97 KBGábor Hojtsy
#1 2031207-language-entity-group-1.patch565 bytesvijaycs85
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented
Status: Active » Needs review
FileSize
2031207-language-entity-group-1.patch565 bytes

Initial patch...

Status: Needs review » Needs work
Issue tags: -Configuration system, -D8MI, -language-config

The last submitted patch, 2031207-language-entity-group-1.patch, failed testing.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Status: Needs work » Needs review
Issue tags: +Configuration system, +D8MI, +language-config

#1: 2031207-language-entity-group-1.patch queued for re-testing.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented

Sent for retest due to #2031255: Update for new languages as config entities.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
FileSize
2031207-language-entity-group-5.patch1.97 KB

Test were needed.

Status: Needs review » Needs work

The last submitted patch, 2031207-language-entity-group-5.patch, failed testing.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Status: Needs work » Needs review
FileSize
2031207-language-entity-group-7.patch2.21 KB

Use statements are useful.

Status: Needs review » Needs work

The last submitted patch, 2031207-language-entity-group-7.patch, failed testing.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Status: Needs work » Needs review
FileSize
2031207-language-entity-group-9.patch2.22 KB

Meh, using the right use is also useful.

Status: Needs review » Needs work

The last submitted patch, 2031207-language-entity-group-9.patch, failed testing.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Status: Needs work » Needs review
FileSize
2031207-language-entity-group-11.patch2.57 KB

All right, the listing cannot be altered yet due to #2005778-22: Convert language_admin_overview_form to a Controller. So we should comment that out for now.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Status: Needs review » Fixed

Yay, committed!

Automatically closed -- issue fixed for 2 weeks with no activity.