Integrate field configuration translation on the user interface

this is a current field list.
we want to add a translate operation to the drop down operations.

This is just my first read. Mostly asking questions so I can try and understand. :)

1. +++ b/config_translation.moduleundefined
   @@ -251,6 +251,31 @@ function config_translation_config_translation_group_info() {
   +  // Fields.
   

   If there are other sections like this,
   we should make the inline comments be sentences...

   We could do that in the whole file in a clean up issue.

   I (or someone) should check this patch in the context of the whole file. I'll do that, but just saving this for now.

2. +++ b/config_translation.moduleundefined
   @@ -251,6 +251,31 @@ function config_translation_config_translation_group_info() {
   +    // Make sure entity type is fieldable.
   +    if ($entity_info['fieldable'] && isset($entity_info['route_base_path'])) {
   

   the if, makes sure it's fieldable..
   and also
   that it has a route base path?

   What is the second part of the condition mean in words?

3. +++ b/config_translation.moduleundefined
   @@ -251,6 +251,31 @@ function config_translation_config_translation_group_info() {
   +        // Remove bundle prefix, if present.
   +        if (isset($entity_info['bundle_prefix']) && strpos($bundle, $entity_info['bundle_prefix']) === 0) {
   +          $bundle = str_replace($entity_info['bundle_prefix'], '', $bundle);
   +        }
   +        // Replace {bundle} placeholder on path.
   +        $path = str_replace('{bundle}', $bundle, $entity_info['route_base_path']) . '/fields/{field_instance}';
   

   what is an example of bundle that has a bundle prefix that needs to be removed.

   is it like:
   comment_node_article
   has comment_node removed,
   so we only use
   article as the bundle?

   ag bundle_prefix core
   yields:
   core/lib/Drupal/Core/Entity/Annotation/EntityType.php
   222: public $bundle_prefix;

   which says:

     /**
      * The prefix for the bundles of this entity type.
      *
      * For example, the comment bundle is prefixed with 'comment_node_'.
      *
      * @var string (optional)
      */
     public $bundle_prefix;
   

4. +++ b/config_translation.moduleundefined
   @@ -251,6 +251,31 @@ function config_translation_config_translation_group_info() {
   +        // To avoid duplicates, save in an array and update $items.
   +        $field_items[$path] = $path;
   

   save what?
   save the path pattern?
   and looks like it updates $field_items, not $items.

   How does saving it avoid duplicates?

5. +++ b/config_translation.moduleundefined
   @@ -251,6 +251,31 @@ function config_translation_config_translation_group_info() {
   +  // Add to group info.
   

   add what to group info?

+++ b/config_translation.moduleundefined
@@ -253,28 +253,17 @@ function config_translation_config_translation_group_info() {
   // Fields.

I checked the other sections are the same. So just leave this.

+++ b/config_translation.moduleundefined
@@ -253,28 +253,17 @@ function config_translation_config_translation_group_info() {
-  foreach ($entity_manager->getDefinitions() as $entity_type => $entity_info) {
-    // Make sure entity type is fieldable.
+    foreach ($entity_manager->getDefinitions() as $entity_type => $entity_info) {
+    // Make sure entity type is fieldable and has base path.

the foreach is gone, so now the code that is there should have indent corrected.

+++ b/config_translation.moduleundefined
@@ -253,28 +253,17 @@ function config_translation_config_translation_group_info() {
+          $items[] = new ConfigEntityMapper("$path/fields/{field_instance}" , 'field_instance', t('@label field'), MENU_CALLBACK);

$path . '/fields/{...'

Gabor says we do concat with single quotes usually

1. going to the field, both the edit and field settings tab do not have the subtabs to translate
2. but if guess the url, like:
   http://localhost/drupal2/admin/structure/types/manage/article/fields/nod...

   do see the translate table. :)

3. clicking on add gives:

   The requested page "/admin/structure/types/manage/article/fields/node.article.body/translate/add/af" could not be found.

oh, and we have yet to add the code to make the translate operation show on the field drop buttons. so that does not work yet either.

Maybe the usual subjects for not working is:
the wrong url (like changing to manage url pattern),
or if the source file has langcode und we will get access denied [this is not happening here, but I'm writing down so I remember in case].