Add tests for custom blocks, contact forms, formats, shortcut listings and settings pages.

Yay! Did you forgot to post the patch? :)

+++ b/lib/Drupal/config_translation/Tests/ConfigTranslationListUITest.phpundefined
@@ -21,7 +21,7 @@ class ConfigTranslationListUITest extends WebTestBase {
-  public static $modules = array('block', 'contact', 'config_translation', 'menu', 'taxonomy');
+  public static $modules = array('block', 'contact', 'config_translation', 'menu', 'taxonomy', 'custom_block', 'shortcut');

@@ -41,6 +41,10 @@ class ConfigTranslationListUITest extends WebTestBase {
       'administer menu',
       'administer site configuration',
       'administer taxonomy',
+      'administer filters',
+      'administer shortcuts',
+      'administer users',
+      'administer permissions',
       'translate configuration',

alphabetical is nice.

+++ b/lib/Drupal/config_translation/Tests/ConfigTranslationListUITest.phpundefined
@@ -128,25 +228,19 @@ class ConfigTranslationListUITest extends WebTestBase {
+    // Test the role settings page.
+    $this->doSettingsPageTest('admin/people/roles');

Role is like the other entities, not a translate tab, but is a listing so needs a test role and then a do like the others.

+++ b/lib/Drupal/config_translation/Tests/ConfigTranslationListUITest.phpundefined
@@ -118,6 +130,119 @@ class ConfigTranslationListUITest extends WebTestBase {
+   * Tests the contact forms listing for the translate operation.
...
+  function doContactFormsListTest() {
...
+    // Get the custom block listing.
+    $this->drupalGet('admin/structure/contact');

this comment should say

// Get the contact form listing.

+++ b/lib/Drupal/config_translation/Tests/ConfigTranslationListUITest.phpundefined
@@ -118,6 +130,119 @@ class ConfigTranslationListUITest extends WebTestBase {
+   * Tests a given settings page for the translate operation.
...
+  function doSettingsPageTest($link) {
+    // Get the maintenance settings page.
+    $this->drupalGet($link);
+
+    $translate_link = $link . '/translate';
+    // Test if the link to translate the settings page is present.

this is testing a generic (given) settings page, not always the maintenance settings page.

Change to:
// Get the settings page.

We might also want to add info that the translate link is usually in a tab on the page?

Attached patch without fix for showing the test broken and patch with fixes mentioned by YesCT.

changed status

looks great!

Committed, yay! Hiperyay! The commit message used was:

Issue #2027587 by kfritsche, David Hernández, dawehner, YesCT: Add tests for custom blocks, contact forms, formats, shortcut listings and settings pages.; fix for user roles from #2019831 included, otherwise tests would not pass; yay

novice followup

#2028067: Clean up the added tests, by not calling procedural wrapper and fixing grammar

Sorry, thanks!