part of #2011290: [meta] standards cleanup to get ready for getting into core
Clean up the following file:
http://drupalcode.org/project/config_translation.git/blob/HEAD:/lib/Drup...

Proposed resolution

Remaining tasks

User interface changes

No

API changes

No

CommentFileSizeAuthor
#3 config_translation.code_delete.2017983-3.patch2.82 KBYesCT
#3 interdiff-1-3.txt1.45 KBYesCT
#1 config_translation.code_delete.2017983-1.patch1.92 KBYesCT
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

YesCT’s picture

YesCT CreditAttribution: YesCT commented
Title: lib/Drupal/config_translation/Form/ConfigTranslationDeleteForm.php standards cleanup to get ready for getting into core » ConfigTranslationDeleteForm.php standards cleanup to get ready for getting into core
Status: Active » Needs review
FileSize
config_translation.code_delete.2017983-1.patch1.92 KB

there was an unused variable, form values.

why are the types:
* @var \stdClass
?

YesCT’s picture

YesCT CreditAttribution: YesCT commented

#1: config_translation.code_delete.2017983-1.patch queued for re-testing.

YesCT’s picture

YesCT CreditAttribution: YesCT commented
FileSize
interdiff-1-3.txt1.45 KB
config_translation.code_delete.2017983-3.patch2.82 KB

found the types.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Status: Needs review » Fixed

Looks great! Much better than before the patch. Thanks a lot!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.