Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
The non-inclusive terms for complete and conditional split config was changed in #2865280: Find a better name for Graylist.
But for compatibility the code remained the same. We now have a active 2.x branch where this can be fixed.
Proposed resolution
change config keys to complete_split, conditional_split, conditional_split_dependents, conditional_split_skip_equal
Remaining tasks
change config keys
change variable names
change comments
write update hook for config
User interface changes
none, this has already changed in 1.x and completed in #3149562: Remove legacy terminology from UI
API changes
changed config keys
Data model changes
changed config keys
| Comment | File | Size | Author |
|---|---|---|---|
| #12 | 3191329-12.patch | 31.97 KB | Diego_Mow |
Comments
Comment #2
Pooja Ganjage CreditAttribution: Pooja Ganjage at Asentech LLC commentedHi,
Creating a patch for this issue.
Please review the patch.
Thanks.
Comment #3
Pooja Ganjage CreditAttribution: Pooja Ganjage at Asentech LLC commentedComment #5
Pooja Ganjage CreditAttribution: Pooja Ganjage at Asentech LLC commentedComment #6
Pooja Ganjage CreditAttribution: Pooja Ganjage at Asentech LLC commentedComment #7
bircherThanks for opening the issue. This was already mentioned in #3149942: [meta] Create 2.x version using the new Drupal 8.8 API and outlined in #3179219: CMI 2 meeting - 2020-11-10.
Thanks also for starting a patch, unfortunately the issue summary was suggesting a word that does not make sense in the context of config split and which has a better alternative already in use for three years.
The most important thing here is to create a update hook that converts all the previous config to the new one.
The real value is not doing a search and replace over the code but writing a update hook that makes sure everyone can use the new version without extra work.
Comment #8
bircherAdding this to the 2.0.0 issues
Comment #9
Cg0rd0noo7 CreditAttribution: Cg0rd0noo7 commented#2865280: Find a better name for Graylist - does not fix this issue regarding legacy terminology. The words blacklist can still be found in the code and in the admin config screen.
Keeping this language in either place is not consistent with the current direction or standards of the community.
https://www.drupal.org/project/drupal/issues/2993575
Comment #10
gregglesI think folks agree that this change is welcome and makes good progress. However, there is still work to do on writing an update hook. That makes sense to me that an update hook is required for this to get committed.
@bircher, you mention a better alternative already in use, can you clarify what words should be used in your opinion? That will make it easier for other folks to contribute to progress here. Maybe that's what is in the summary now as I see it matches with the comment about legacy terminology in #3149942.
Comment #11
bircherYes I updated the issue summary with my comment in #7. So it should be pretty clear what to do.
Comment #12
Diego_Mow CreditAttribution: Diego_Mow as a volunteer and at CI&T commentedHi.
Uploading patch 12 by removing some still existence references to blacklist on the code.
Also I propose to change graylist to overridelist to maintain consistency and clearance.
Still working on Update Hook thought, so I will leave it as "Needs Work".
Comment #13
bircherthanks for the patch.
Though it still uses terminology from #5 that is wrong. I updated the issue summary with better names in #7.
That said I am refactoring the code quite a bit for #3170204: Add option to remove modules as if they were uninstalled and #2934170: Add partial split for specific keys so the real contribution that is needed here is to write the update hook.
See also #3215319: Request for feedback: replace conditional split with partial split. which would mean the name can change yet again.. What I am trying to say is that rather than grepping the code we need the update hook. If the update hook is introduced as part of any of other issues then we can grep the code for any remaining legacy terminology.
Comment #14
bircher