First of all, thank you for this module. It really helps during development phase. While reviewing the module, I found a lot of PHP code sniffer issues in the code.
I have tried to fix them, attached patch file has fix for those issues. Please review and commit those changes in next release.

Thank you

CommentFileSizeAuthor
#3 php-code-sniffer-issues-2841803-3.patch2.38 KBpauloamgomes
PHPCS_fixes.patch1.66 KBumed91
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

umed_singh created an issue. See original summary.

umed91’s picture

umed91 CreditAttribution: umed91 commented
Assigned: umed91 » Unassigned
pauloamgomes’s picture

pauloamgomes CreditAttribution: pauloamgomes as a volunteer and at Appnovation commented
FileSize
php-code-sniffer-issues-2841803-3.patch2.38 KB

Updated previous patch with remaining phpcs issues and also updated array declaration to short array format as per https://www.drupal.org/node/2776975 discussion.

laszlo.kovacs’s picture

laszlo.kovacs
Location Budapest
CreditAttribution: laszlo.kovacs commented
Status: Needs review » Fixed
Balu Ertl’s picture

Balu Ertl
he/him
Primary language Hungarian
Location Budapest 🇪🇺
CreditAttribution: Balu Ertl as a volunteer and at Cheppers commented
Title: PHP Code Sniffer issues. » PHP Code Sniffer issues

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.