Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
When [content_translation] module is enabled,
And we enable [Custom Permissions],
And we go to "Any people links " or some other links
Then we will get Route "custom_perms_select_list_form" does not exist
Comment | File | Size | Author |
---|---|---|---|
#16 | 2877329-16.patch | 1.88 KB | Rajab Natshah |
Comments
Comment #2
Rajab Natshah CreditAttribution: Rajab Natshah at Vardot commented-
Comment #3
Rajab Natshah CreditAttribution: Rajab Natshah at Vardot commentedComment #4
Rajab Natshah CreditAttribution: Rajab Natshah at Vardot commentedComment #5
Rajab Natshah CreditAttribution: Rajab Natshah at Vardot commentedComment #6
Rajab Natshah CreditAttribution: Rajab Natshah at Vardot commentedComment #7
Rajab Natshah CreditAttribution: Rajab Natshah at Vardot commentedComment #8
josebc CreditAttribution: josebc at Vardot commentedthis is related to this change record https://www.drupal.org/node/2306387, issue was a conflict with config_translate module
patch attached
Comment #9
Mohammed J. RazemWorking well.
Comment #10
Rajab Natshah CreditAttribution: Rajab Natshah at Vardot commentedComment #11
Rajab Natshah CreditAttribution: Rajab Natshah at Vardot commentedWorks well when we enable the module with the patch after complete installation of the system.
Seems that we will have an issue:
ResponseText: RuntimeException: Recursive router rebuild detected. in Drupal\Core\Routing\RouteBuilder->rebuild() (line 121 of /var/www/html/dev/varbase4c/docroot/core/lib/Drupal/Core/Routing/RouteBuilder.php).
In the installation step of a custom drupal profile
As we do not have any registered route from the Drupal Core yet.
Something wrong in:
To Reproduce
So if we have:
In a custom profile, we will have the same issue
Comment #12
josebc CreditAttribution: josebc at Vardot commentedNot a pretty solution but fixes issue on installation
Comment #13
Rajab Natshah CreditAttribution: Rajab Natshah at Vardot commentedThank you @Jose, It's all your debugging and tracing in the code.
I will use and test in the install.
Comment #14
Rajab Natshah CreditAttribution: Rajab Natshah at Vardot commentedTested by humans, and robots
Comment #15
Rajab Natshah CreditAttribution: Rajab Natshah at Vardot commentedComment #16
Rajab Natshah CreditAttribution: Rajab Natshah at Vardot commentedUpdated the patch to work with 8.x-1.1
Comment #17
Rajab Natshah CreditAttribution: Rajab Natshah at Vardot commentedComment #18
gnugetI just reviewed #12 and I don't think that is the best approach for this.
The problem is that we have a links handler in the entity annotations (See CustomPermsEntity.php) BUT we haven't any route in the routing file nor a route_provider in the entity... so the routes for those links don't exist and that makes this problem.
Accord with [#2306387] we need to provided at least a canonical link, so my proposed solution is:
I'm working on a new branch for this module, which fixes a major problem (see #2894471: Custom Permission for Site Information Page) and there I will fix this as well, would be great if later can you help me to test my fix there.
I will leave a comment when it's done.
Thanks!
Comment #19
gnugetI just pushed a change on the branch 8.x-2.x would be great if you help me to test if that fixes the issue.
Just remember that the branch 8.x-2.x doesn't even have an alpha release yet, so for now just test it in a dev environment.
Thanks!
Comment #20
Rajab Natshah CreditAttribution: Rajab Natshah at Vardot commentedTested with config_perms 8.x-2.0-beta1
#2961223: Updated [Custom Permissions] module from 8.1.1 to 8.2.0-beta1
https://travis-ci.org/Vardot/varbase/builds/366849138
Comment #21
gnugetDoes #20 mean that we can close this issue?
😃
Comment #22
Rajab Natshah CreditAttribution: Rajab Natshah at Vardot commentedYes, Thank you :)
closing this issue.