Problem/Motivation
Hello project maintainers,
This is an automated issue to help make this module compatible with Drupal 11.
Changes will periodically be added to this issue that remove deprecated API uses. To stop further changes from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD11" tag from the issue to stop the bot from posting updates.
The changes will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.
Proposed resolution
You have a few options for how to use this issue:
- Accept automated changes until this issue is closed
If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD11" tag is left on this issue, new changes will be posted periodically if new deprecation fixes are needed.
As the Drupal Rector project improves and is able to fix more deprecated API uses, the changes posted here will cover more of the deprecated API uses in the module.
Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot changes. The bot will still post new changes then if there is a change in the new generated patch compared to the changes that the bot posted last. Those changes are then up to humans to integrate.
- Leave open but stop new automated changes.
If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated changes, remove the "ProjectUpdateBotD11" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated changes again, add back the "ProjectUpdateBotD11" tag.
- Close it and don't use it
If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated changes will be posted here.
If the issue is reopened, then new automated changes will be posted.
If you are using another issue(s) to work on Drupal 11 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.
Remaining tasks
Using the patches
- Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
- Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
- Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.
Using the merge request
- Review the merge request and test it.
- Thoroughly test the changes. These changes are automatically generated so they haven't been tested manually or automatically.
- Provide feedback about how the testing went. If you can improve the merge request, create a new branch and merge request and work from there.
Warning: The 'project-update-bot-only' branch will always be overwritten. Do not work in that branch!
Providing feedback
If there are problems with one of the changes posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.
| Comment | File | Size | Author |
|---|---|---|---|
| #39 | 3428552-39.patch | 1 KB | keshavv |
| #37 | 3428552-update-drupal-11-config-override-warn-37.patch | 3.32 KB | usingsession |
| #17 | config_override_warn.1.x-dev.upgrade_status.post_rector.txt | 3.37 KB | project update bot |
Issue fork config_override_warn-3428552
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
project update bot commentedThis is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module, even with these changes, this module is not yet compatible with Drupal 11.
Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.
Therefore these changes did not update the
info.ymlfile for Drupal 11 compatibility.Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug info
This patch was created using these packages:
Comment #4
project update bot commentedThis is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update the
info.ymlfile for Drupal 11 compatibility.Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug info
This patch was created using these packages:
Comment #5
project update bot commentedThis is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update the
info.ymlfile for Drupal 11 compatibility.Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug information
These packages were used to generate the fixes:
Comment #6
project update bot commentedThis is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update the
info.ymlfile for Drupal 11 compatibility.Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug information
These packages were used to generate the fixes:
Comment #7
v.dovhaliuk commentedComment #8
jamesoakleyMaybe there's a prior question of whether this module is still needed? #3462541: Difference with what is now in core?
Comment #12
deimos commentedGreetings,
I merged bot's changes and added corrections to get tests green. They were failed due to changes done in #3395913: Correct spelling in Config tests, specifically this changes.
Also I checked test on D11 and added fixes to get them working as well.
Changes were pushed into
3428552-automated-drupal-11Comment #13
deimos commentedIssue reported by Update Status module can be ignored till Drupal 12 release.
Comment #14
prudloff commentedTests on the MR look OK.
I also did some manual testing and it seems to work correctly: the warning is displayed only when it is not already handled by core.
Comment #15
prudloff commentedHiding patches to focus on the MR.
Comment #16
roderikJust for the people only reading this issue:
Yes, it's been established that this is still needed, in #3462541-4: Difference with what is now in core? and further.
So a merge + release is appreciated.
Comment #17
project update bot commentedThis is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module, even with these changes, this module is not yet compatible with Drupal 11.
Currently Drupal Rector, version 0.20.3, cannot fix all Drupal 11 compatibility problems.
Therefore, these changes did not update the
info.ymlfile for Drupal 11 compatibility.The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.
Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug information
These packages were used to generate the fixes:
Comment #20
anairamzapHi, I've tested the automated update bot changes + the changes made by @deimos in PR4 #3428552-13: Automated Drupal 11 compatibility fixes for config_override_warn and everything looks ok.
I had to create a new branch for the latest stable
8.x-1.4release since we need D11 compatibility for a project.Can we please have a new release created with these changes?
Thanks!
Mariana
Comment #21
bserem commentedMR !6 doesn't apply properly (patching via composer). MR !4 does
Comment #22
project update bot commentedThis is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update the
info.ymlfile for Drupal 11 compatibility.Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug information
These packages were used to generate the fixes:
Comment #25
usingsession commentedIn PR4 Issue #3428552: Drupal 11 compatibility fixes for config_override_warn everything looks ok (for 8.x-1.x-dev).
But I created new PR based on it, because in my opinion, I see no reason to wait for Drupal 12 to remove Renderer::renderPlain().
Comment #28
usingsession commentedAbout 3428552-drupal-compatibility-fixes-stable-1.4 - I tried to create a patch for module1.4, but composer.json always fails.
!MR6 - also fails
Comment #30
prudloff commentedWe now have 4 MRs on this issue, which one should be reviewed?
Comment #32
usingsession commented@prudloff, I believe the correct one to review is MR !4
Comment #35
prudloff commentedComment #37
usingsession commentedAs @anairamzap mentioned above, if you need a patch for the stable version 8.x-1.4, you can use the attached one.
Comment #39
keshavv commentedPatch for https://www.drupal.org/project/config_override_warn/releases/8.x-1.x-dev
Comment #40
nala-he commentedHi, I’ve tested 3428552-39.patch (for 8.x-1.x-dev), MR !4, and MR !7 on Drupal 11.2.3.
I was able to composer install these patches using the
mglaman/composer-drupal-lenientcomposer plugin withddev composer require 'drupal/config_override_warn:1.x-dev@dev'.The three tested patches deliver identical warning behavior. For a D11 compatibility upgrade ticket, 3428552-39.patch probably follows better practices with minimal changes (e.g. no changes on test wording). The removal of deprecated
renderPlain()also provides forward compatibility for D12. (MR!7 is the combination of MR !4 and 3428552-39.patch)Comment #41
prudloff commented