First of all thanks for the useful module!

I've patched the module to serve our needs a bit better and thought the module could use the improvement as well. The Slack change notification is very handy but knowing what has changed can be even more useful. In our case, the client has access to an admin-level account and makes changes that sometimes require our immediate attention (depending on the config changes). This improvement helps with acting on time. I've attached the patch including the changes we made.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mleprohon created an issue. See original summary.

fjgarlin’s picture

Status: Active » Needs work

Thanks for the suggestion/patch. A couple of things/suggestions though.

* The "```" is specific to slack, so that won't probably render nicely on an email. We'd need to find a solution that displays nicely on any service.
* Also, whilst this feature might be useful to the case you're working on, it might not always be needed. For this, I suggest adding a checkbox for "Verbose output" or similar, and when checked, this additional information could be added to the message.

If I find the time I can work on these suggestions soon, but you're also welcome to give them a go.

Best.

fjgarlin’s picture

Version: 8.x-1.2 » 8.x-1.x-dev
3li’s picture

Have taken the original patch and expanded upon it.

  • Added option to enable listing config changes.
  • Added option to limit the number of config changes - if there are more than the limit message will state how many more changes.
  • Added slack only formatting

Created the patch on 8.x-1.2 but also tested it on 8.x-1.x-dev.

3li’s picture

Example images of the new notifications.

fjgarlin’s picture

Thanks @elistone.

Uploading patch with same approach you followed, but refactoring a bit the message generation (hopefully simplifying it a bit) and applying coding standards.

  • fjgarlin committed c9b0ce3 on 8.x-1.x
    Issue #3128111 by Eli.Stone, fjgarlin, mleprohon: List the config...
fjgarlin’s picture

Status: Needs work » Fixed

Thanks Eli.Stone and mleprohon. I've committed the above patch. Thanks for your patches and ideas!

fjgarlin’s picture

Status: Fixed » Closed (fixed)