Daily automated core config validatability report broke on March 23

variable type is integer but applied schema class is Drupal\Core\TypedData\Plugin\DataType\BooleanData

… but --statistics never prints that output!

That made it much harder to track down than it should've been. Fixed that bit in the MR already. Now to track down the root cause…

… actually, the root cause is much simpler and happens after March 23, when it tries to assess revision d671f38a0e4b563:

$ ./vendor/bin/drush config:inspect --statistics
➜                                                                                    
➜                      1 errors in block.block.claro_page_title:                     
➜       [block.block.claro_page_title:settings.base_route_title] missing schema      
➜                                                                                    
➜                                                                                    
➜                     1 errors in block.block.olivero_page_title:                    
➜      [block.block.olivero_page_title:settings.base_route_title] missing schema     
➜                                                                                    
 [error]  Error: Class "Drupal\ckeditor5\Plugin\CKEditor4To5UpgradePluginManager" not found in Drupal\Component\DependencyInjection\Container->createService() (line 258 of /Users/wim.leers/core/core/lib/Drupal/Component/DependencyInjection/Container.php) #0 /Users/wim.leers/core/core/lib/Drupal/Component/DependencyInjection/Container.php(444): Drupal\Component\DependencyInjection\Container->createService(Array, 'plugin.manager....')
#1 /Users/wim.leers/core/core/lib/Drupal/Component/DependencyInjection/Container.php(236): Drupal\Component\DependencyInjection\Container->resolveServicesAndParameters(Array)
#2 /Users/wim.leers/core/core/lib/Drupal/Component/DependencyInjection/Container.php(176): Drupal\Component\DependencyInjection\Container->createService(Array, 'ckeditor5.smart...')
#3 /Users/wim.leers/core/core/modules/ckeditor5/src/Plugin/Editor/CKEditor5.php(151): Drupal\Component\DependencyInjection\Container->get('ckeditor5.smart...')
#4 /Users/wim.leers/core/core/lib/Drupal/Core/Plugin/Factory/ContainerFactory.php(21): Drupal\ckeditor5\Plugin\Editor\CKEditor5::create(Object(Drupal\Core\DependencyInjection\Container), Array, 'ckeditor5', Array)
#5 /Users/wim.leers/core/core/lib/Drupal/Component/Plugin/PluginManagerBase.php(83): Drupal\Core\Plugin\Factory\ContainerFactory->createInstance('ckeditor5', Array)
#6 /Users/wim.leers/core/core/modules/editor/src/Entity/Editor.php(105): Drupal\Component\Plugin\PluginManagerBase->createInstance('ckeditor5')
#7 /Users/wim.leers/core/core/lib/Drupal/Core/Config/Entity/ConfigEntityStorage.php(222): Drupal\editor\Entity\Editor->__construct(Array, 'editor')
#8 /Users/wim.leers/core/core/lib/Drupal/Core/Entity/EntityStorageBase.php(232): Drupal\Core\Config\Entity\ConfigEntityStorage->doCreate(Array)
#9 /Users/wim.leers/core/core/lib/Drupal/Core/Entity/EntityBase.php(523): Drupal\Core\Entity\EntityStorageBase->create(Array)
#10 /Users/wim.leers/core/core/modules/ckeditor5/src/Plugin/Validation/Constraint/TextEditorObjectDependentValidatorTrait.php(53): Drupal\Core\Entity\EntityBase::create(Array)
#11 /Users/wim.leers/core/core/modules/ckeditor5/src/Plugin/Validation/Constraint/EnabledConfigurablePluginsConstraintValidator.php(72): Drupal\ckeditor5\Plugin\Validation\Constraint\EnabledConfigurablePluginsConstraintValidator->createTextEditorObjectFromContext()
#12 /Users/wim.leers/core/core/modules/ckeditor5/src/Plugin/Validation/Constraint/EnabledConfigurablePluginsConstraintValidator.php(34): Drupal\ckeditor5\Plugin\Validation\Constraint\EnabledConfigurablePluginsConstraintValidator->getConfigurableEnabledDefinitions()
#13 /Users/wim.leers/core/core/lib/Drupal/Core/TypedData/Validation/RecursiveContextualValidator.php(202): Drupal\ckeditor5\Plugin\Validation\Constraint\EnabledConfigurablePluginsConstraintValidator->validate(Array, Object(Drupal\ckeditor5\Plugin\Validation\Constraint\EnabledConfigurablePluginsConstraint))
#14 /Users/wim.leers/core/core/lib/Drupal/Core/TypedData/Validation/RecursiveContextualValidator.php(154): Drupal\Core\TypedData\Validation\RecursiveContextualValidator->validateConstraints(Array, '0000000000001b8...', Array)

… due to #3239012: [11.x] Remove the CKEditor 4 upgrade path.

It's the commit of #3370946: Page title should contextualize the local navigation and subsequent revert that exposed this weakness:

• block_post_update_add_base_route_title_page_title() updated all page_title_block blocks
• … and type: block.settings.page_title_block was defined too, so all was well!
• BUT then that commit was reverted in 192c0f5dea648097c6c2191e67f2622ba2acb6a2, which subsequently caused the update path to be reverted too, now leaving the updated config in a non-compliant state!

Yay, got past that!

The next problem occurs ~1 week later:

🕰️  2024-03-28 00:00:00 +00:00 → 35.80% (e1e95969a1 Issue #3352256 by e0ipso, plopesc, bbrala, longwave, dww, catch, larowlan: Move code from the experimental SDC module to core)
PHP Fatal error:  Uncaught Error: Class "Drupal\Core\EventSubscriber\RequestCloseSubscriber" not found in /builds/project/config_inspector/core/lib/Drupal/Component/DependencyInjection/Container.php:258
Stack trace:
#0 /builds/project/config_inspector/core/lib/Drupal/Component/DependencyInjection/Container.php(176): Drupal\Component\DependencyInjection\Container->createService(Array, 'request_close_s...')
#1 /builds/project/config_inspector/core/lib/Drupal/Component/EventDispatcher/ContainerAwareEventDispatcher.php(105): Drupal\Component\DependencyInjection\Container->get('request_close_s...')
#2 /builds/project/config_inspector/vendor/symfony/http-kernel/HttpKernel.php(115): Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch(Object(Symfony\Component\HttpKernel\Event\TerminateEvent), 'kernel.terminat...')
#3 /builds/project/config_inspector/core/lib/Drupal/Core/StackMiddleware/StackedHttpKernel.php(63): Symfony\Component\HttpKernel\HttpKernel->terminate(Object(Symfony\Component\HttpFoundation\Request), Object(Drupal\Core\Render\HtmlResponse))
#4 /builds/project/config_inspector/core/lib/Drupal/Core/DrupalKernel.php(679): Drupal\Core\StackMiddleware\StackedHttpKernel->terminate(Object(Symfony\Component\HttpFoundation\Request), Object(Drupal\Core\Render\HtmlResponse))
#5 /builds/project/config_inspector/vendor/drush/drush/src/Boot/DrupalBoot8.php(326): Drupal\Core\DrupalKernel->terminate(Object(Symfony\Component\HttpFoundation\Request), Object(Drupal\Core\Render\HtmlResponse))
#6 [internal function]: Drush\Boot\DrupalBoot8->terminate()
#7 {main}
  thrown in /builds/project/config_inspector/core/lib/Drupal/Component/DependencyInjection/Container.php on line 258
🤖                               Erasing discovery cache because config schema changed…
🤖                               Rebuilding container because validation constraints were added or modified…
🤖                               Rebuilding container because services changed…
🕰️  2024-03-29 00:00:00 +00:00 → 35.97% (56141280b4 Issue #3436761 by simohell: Remove default event from collpased nav-tabs button)

Due to the changes committed in #3436599: Replace RequestCloseSubscriber with needs_destruction tag on ModuleHandler, which Drush is affected by. But … this does not cause a hard crash, and everything continues just fine 👍

If PHP 8.3 works for 11.x going back to November 2022 … we'd be good to go 🤞

That worked: https://git.drupalcode.org/project/config_inspector/-/jobs/1224322/artif... — so merged it! 😄