Support from Acquia helps fund testing for Drupal Acquia logo

Comments

vijaycs85’s picture

Status: Active » Needs review
FileSize
3.19 KB

patch fixes below issues:

1. Fix the controller to use hasSchema() method.
2. Adding help text to say that the overview page displays only config with schema.
3. Adding title to overview page.
4. Adding form support for color_hex data type from #2245729: Add missing configuration schema in Color component

vijaycs85’s picture

Issue tags: +Needs tests

We can add test for all 4 items in #1

Gábor Hojtsy’s picture

Status: Needs review » Needs work

Now that I look at this I think this would be be a better debugging tool if the schema-less items would be displayed also but not linked (no operations, or "No schema available" printed in place of operations). At least you would know those are there and what is the problem if you cannot inspect them. Otherwise looks like good simplification.

amitgoyal’s picture

Status: Needs work » Needs review
FileSize
4.32 KB

@Gábor - Please see updated patch. Schema-less items would be displayed but not linked.

Gábor Hojtsy’s picture

Status: Needs review » Fixed
Issue tags: -Needs tests
FileSize
5.43 KB
3.17 KB

- Fixed hook_help text to give more help.
- Fixed hook_help signature so it works with current request based system.
- Fixed listing of no-schema items to allow review of raw data.
- Improved raw data callback so it can work without a schema depicting missing schema as NULL.
- Committing this one in the interest of marching forward helping core find places where it has no schema. We should add more tests later on anyway :) #2253749: Add test for all route controllers should add tests.

  • Commit 2134a17 on 8.x-1.x by Gábor Hojtsy:
    Issue #2257455 by Gábor Hojtsy, amitgoyal, vijaycs85: Code clean up: Fix...
vijaycs85’s picture

thanks @Gábor Hojtsy.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.