Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

CommentFileSizeAuthor
#24 Drupal-10.png277.54 KBarunkumark
#16 Conditional_fields.png14.9 KBBushra Shaikh
#14 3286636-14.patch13.79 KBheddn
#4 conditional_fields-hide.png20.78 KBadrianm6254
#4 conditional_fields-show.png130.01 KBadrianm6254
#2 conditional_fields.4.x-dev.rector.patch461 bytesproject update bot

Issue fork conditional_fields-3286636

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

project update bot commented
Status: Active » Needs review
StatusFileSize
new conditional_fields.4.x-dev.rector.patch461 bytes

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module this patch makes this module compatible with Drupal 10! 🎉
This patch updates the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #127

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.9
  2. palantirnet/drupal-rector: 0.12.0
adrianm6254’s picture

adrianm6254 commented
Issue summary: View changes

I will be reviewing this patch using Drupal 10.

adrianm6254’s picture

adrianm6254 commented
StatusFileSize
new conditional_fields-show.png130.01 KB
new conditional_fields-hide.png20.78 KB

I was able to install conditional_fields module and apply the patch successfully.

Once installed I created an article with a field to select visible or not visible. I configured a condition to make the body field visible or invisible depending on the setting selected. Everything worked as expected.

adrianm6254’s picture

adrianm6254 commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Drupal 10 porting day
kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented

@Adrianm6254 Thanks for participating in porting day and testing this!

I see that @colan did the last commit about 4 months ago so maybe they can get to this one soon :)

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs review

I'm changing this back to "Needs review" so that further patches can be included per the issue summary. We can let the maintainer of the module decide whether they would prefer to close the issue to further patches.

If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review or Needs work) and no more automated patches will be posted here

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented

Thanks everyone for participating in porting day!

There isn't currently consensus on using RTBC on these bot issues so we'll be discussing that at the next #d10readiness meeting :)

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Status: Needs review » Reviewed & tested by the community

Finally getting back to these. We did talk about marking these RTBC in a couple #d10readiness meetings and the consensus was to mark them RTBC as long as the module/theme was actually tested on Drupal 10 and was working as expected and the code changes look okay.

It appears that the module was tested on Drupal 10 per #4 so moving to RTBC.

project update bot’s picture

project update bot commented
Issue summary: View changes

redndahead made their first commit to this issue’s fork.

alphex’s picture

alphex commented
Issue summary: View changes

Will there be a stable category release for D10?

heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
Status: Reviewed & tested by the community » Needs work

NW again because between #4 and the release of Drupal 10, ckeditor was deprecated.

Upgrade Status report

Contributed projects

Conditional Fields 4.0.0-alpha1

Scanned on Tue, 12/27/2022 - 11:50.
3 warnings found.

Check manually

Errors without Drupal source version numbers including parse errors and use of APIs from dependencies.
File name Line Error
web/modules/contrib/conditional_fields/conditional_fields.module 242 File modules/contrib/conditional_fields/conditional_fields.api.inc could not be loaded from module_load_include.
web/modules/contrib/conditional_fields/conditional_fields.libraries.yml 0 The 'conditional_fields' library is depending on a deprecated library. The "core/ckeditor" asset library is deprecated in drupal:9.5.0 and is removed from drupal:10.0.0. There is no replacement. See https://www.drupal.org/node/3304481
web/modules/contrib/conditional_fields/conditional_fields.info.yml 0 Value of core_version_requirement: ^8 || ^9 is not compatible with the next major version of Drupal core. See https://drupal.org/node/3070687..

Ignore

Deprecated API use for APIs removed in future Drupal major versions is not required to fix yet.
File name Line Error
web/modules/contrib/conditional_fields/conditional_fields.module 242 Call to deprecated function module_load_include(). Deprecated in drupal:9.4.0 and is removed from drupal:11.0.0. Use Drupal::moduleHandler()->loadInclude($module, $type, $name = NULL). Note that including code from uninstalled extensions is no longer supported.

heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
Status: Needs work » Needs review
StatusFileSize
new 3286636-14.patch13.79 KB

Actually, my comments in #13 wasn't on 4.x-dev branch but the latest tagged release.

Most of the issues flagged in that comment are addressed, except for the version change and test fixes.

Refer to

  1. #3216638: Remove ckeditor from dependencies list
  2. #3134427: Remove needless module_load_include() from module file

This gets tests to pass green, at least locally. Hopefully also the testbot agrees. I also did some minor click testing on drupal 10.1. Not extensive, but enough to know that the module installs and _seems_ to work still.

Bushra Shaikh’s picture

Bushra Shaikh commented
Assigned: Unassigned » Bushra Shaikh

I have verified the patch #14 on drupal 10.1-x version, patch applied successfully and looks good to me.

Can be moved to RTBC+1

Bushra Shaikh’s picture

Bushra Shaikh commented
StatusFileSize
new Conditional_fields.png14.9 KB
Bushra Shaikh’s picture

Bushra Shaikh commented
Assigned: Bushra Shaikh » Unassigned

rfmarcelino made their first commit to this issue’s fork.

rfmarcelino opened merge request !19

heddn’s picture

heddn
Primary language English
Location Nicaragua
commented

Any chance this can be committed and a new version tagged that lists Drupal 10 support?

ressa’s picture

ressa
he/him
commented

At the same time, the project page text could also get updated?

Conditional Fields for Drupal 7 is an user interface ...

@Bushra Shaikh: Perhaps you can change Status to RTBC, to alert the maintainers that the patch applies and works well?

heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
Status: Needs review » Reviewed & tested by the community
loopy1492’s picture

loopy1492 commented

Patch applied and seems to make Upgrade Status module happy on 9.5.2 with php 8.1.

arunkumark’s picture

arunkumark
Location Coimbatore
commented
StatusFileSize
new Drupal-10.png277.54 KB

I tested the module with Drupal 10.0.x version. The patch was applied cleanly and worked as expected.

D10

+RTBC

scotwith1t’s picture

scotwith1t
Location Birmingham, AL
commented

+1 for new release with #14 applied. Thanks!

  • heddn committed a8ffc7a7 on 4.x 
    Issue #3286636 by heddn, Bushra Shaikh, arunkumark: Automated Drupal 10...
heddn’s picture

heddn
Primary language English
Location Nicaragua
commented

Thanks everyone for your patience and assistance with testing this patch. I've committed it and updated the testbot configuration to include a weekly D10 test run.

heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

heddn closed merge request !19