Select::statesHandler() expects the $select_states variable to be initialized, but that's not guaranteed to be the case. As it turns out, the variable ends up being assigned to the $states variable before being returned anyway. I've fixed the issue by renaming the $select_states variable to $states.

CommentFileSizeAuthor
#8 conditional_fields-select_states_php_notice-2897468-8.patch1.11 KBbrad.bulger
#7 conditional_fields-select_states_php_notice-2897468-7.patch1.11 KBhawkeye.twolf
#4 undefined_index_select_states_2897468-4.patch987 bytesBaysaa
undefined_index_select_states.patch1.1 KBlegolasbo
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

legolasbo created an issue. See original summary.

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
CreditAttribution: colan at Colan Schwartz Consulting commented
Status: Needs review » Postponed (maintainer needs more info)

Patch no longer applies. Is this still a problem after upgrading to the latest dev (8.x-1.0-alpha3 with #2873350: Warning: Invalid argument supplied for foreach() in Drupal\conditional_fields\Plugin\conditional_fields\handler\Select->statesHandler)?

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
CreditAttribution: colan at Colan Schwartz Consulting commented
Related issues: +#2925646: Undefined variable: select_states in Drupal\conditional_fields\Plugin\conditional_fields\handler\Select->statesHandler() and Invalid argument supplied for foreach() in Drupal\conditional_fields\Plugin\conditional_fields\handler\Select->statesHandler()

Marked #2925646: Undefined variable: select_states in Drupal\conditional_fields\Plugin\conditional_fields\handler\Select->statesHandler() and Invalid argument supplied for foreach() in Drupal\conditional_fields\Plugin\conditional_fields\handler\Select->statesHandler() as a duplicate of this issue.

Baysaa’s picture

Baysaa CreditAttribution: Baysaa as a volunteer commented
FileSize
undefined_index_select_states_2897468-4.patch987 bytes

Here's a reroll against alpha4. I believe patch is still needed to prevent notices.

Baysaa’s picture

Baysaa CreditAttribution: Baysaa as a volunteer commented
Status: Postponed (maintainer needs more info) » Needs review
Baysaa’s picture

Baysaa CreditAttribution: Baysaa as a volunteer commented
Status: Needs review » Needs work

I'll reroll against the dev version later.

hawkeye.twolf’s picture

hawkeye.twolf
they/them or he/him
Primary language English
Location ᏙᎩᏯᏍᏗ Unalatogiyasdi, Tsalaguwetiyi (Cherokee country)
CreditAttribution: hawkeye.twolf at Kalamuna commented
FileSize
conditional_fields-select_states_php_notice-2897468-7.patch1.11 KB

Here's the re-roll. Note that the previous re-roll missed a crucial change (deletion of the final variable assignment).

brad.bulger’s picture

brad.bulger CreditAttribution: brad.bulger commented
FileSize
conditional_fields-select_states_php_notice-2897468-8.patch1.11 KB

Current code is still referencing $select_states when it shouldn't. The patch in 7 assigns to $states which is not returned. It should just use $state. Re-roll attached.

dqd’s picture

dqd
(formerly "diqidoq")
CreditAttribution: dqd as a volunteer and at MAROQQO studios commented
Version: 8.x-1.x-dev » 4.x-dev
Status: Needs work » Postponed (maintainer needs more info)

Thanks for the report and all the efforts/work in here! +1

Is this fix still required and if, it surely needs a re-roll? Thoughts?