Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
In conditional_fields.api.inc, there is a function named conditional_fields_load_dependencies_entity() which does not implement a hook, and is not called anywhere in the conditional_fields module code.
Proposed resolution
Delete the function.
Remaining tasks
Maintainer: confirm the function is not needed(assuming done if accepted)Write a patchReview and feedbackRTBC and feedbackCommit
User interface changes
None.
API changes
The function conditional_fields_load_dependencies_entity() is deleted.
Data model changes
None.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | 2890740-2-conditional_fields_load_dependencies_entity-not-used.patch | 1.15 KB | mparker17 |
Comments
Comment #2
chaitanya17 CreditAttribution: chaitanya17 at Cybage Software Pvt Ltd. for Cybage Software Pvt Ltd. commentedComment #3
chaitanya17 CreditAttribution: chaitanya17 at Cybage Software Pvt Ltd. for Cybage Software Pvt Ltd. commentedComment #4
chaitanya17 CreditAttribution: chaitanya17 at Cybage Software Pvt Ltd. for Cybage Software Pvt Ltd. commentedComment #5
mparker17Here's a patch.
Comment #6
chaitanya17 CreditAttribution: chaitanya17 at Cybage Software Pvt Ltd. for Cybage Software Pvt Ltd. commented@mparker17, let me know, If you are working on it.
Else I will verify this function usage.
Comment #7
chaitanya17 CreditAttribution: chaitanya17 at Cybage Software Pvt Ltd. for Cybage Software Pvt Ltd. commentedComment #8
mparker17@chaitanya17, sorry for the confusion.
When I open a new issue that I also plan to write a patch for, I usually create the issue without the patch but assign the issue to me, so that I get an issue ID, which I can then use to name the patchfile. Then I create the patchfile, upload it, and unassign myself.
You can read my patching process here: http://openconcept.ca/blog/mparker/best-practices-generating-patches-and...
Generally, if you see an issue assigned to someone, it means that person is actively working on it — it's usually a good idea to ask (and give the other person a chance to respond) before re-assigning it.
***
There is now a patch attached, so I'm marking the status as "Needs review". Since you seem interested in helping out with this issue, I will leave it assigned to you so that you can review. If you don't want to review, please unassign yourself.
Comment #10
colanThanks for a patch that can be applied with
git am, but the commit message didn't follow the standard so I amended the commit to fix.This sort of clean-up is certainly appreciated!
Comment #11
mparker17Sorry for the useless commit message... I usually write the commit message for myself (i.e.: so I can keep track of things going on in my local branches, of which there are often many)... I considered using the message in the "Credit and committing" fieldset on the issue form, but I realized doing so would leave out commit credits for the people who review my patch after I post it, which is just as important! :)
Thanks for committing! :D
Updating the issue summary's remaining tasks.
Comment #12
colan