I think I was too worried about conflicts if two different subqueues tried to claim the same item, but this makes the code forcibly dependent on the database queues. It should be entirely possible to just not generate the unique subqueue names and process the queues like normal.

CommentFileSizeAuthor
#2 2358291-simplify-subqueue-logic.patch10.46 KBdave reid
#1 2358291-simplify-subqueue-logic.patch7.6 KBdave reid

Comments

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Active » Needs review
StatusFileSize
new 2358291-simplify-subqueue-logic.patch7.6 KB

Ok let's try this.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
StatusFileSize
new 2358291-simplify-subqueue-logic.patch10.46 KB

Final version.cancel

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs review » Closed (won't fix)

Nevermind, it looks like this actually messes with execution order. Using this code only the first subqueue is able to grab items, and the second subqueue queue keeps failing the claimItem() method and ends up processing nothing.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Closed (won't fix) » Active

Re-investigating this...