Todo: Run a deprecated code report for the Composer Security Checker module.

CommentFileSizeAuthor
#7 composer_security_checker-n3111074-7.patch422 bytesdamienmckenna

Comments

DamienMcKenna created an issue. See original summary.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Issue summary: View changes
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Issue summary: View changes
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Issue tags: +Drupal 9 compatibility
damienmckenna’s picture

damienmckenna
Location TN, USA
commented 
$ drupal-check *
 22/22 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ -------------------------------------------------------------------------------------------------------------- 
  Line   spec/Collections/AdvisoryCollectionSpec.php                                                                   
 ------ -------------------------------------------------------------------------------------------------------------- 
         Class spec\Drupal\composer_security_checker\Collections\AdvisoryCollectionSpec was not found while trying to  
         analyse it - autoloading is probably not configured properly.                                                 
 ------ -------------------------------------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------------------------------------ 
  Line   spec/Models/AdvisorySpec.php                                                                                
 ------ ------------------------------------------------------------------------------------------------------------ 
         Class spec\Drupal\composer_security_checker\Models\AdvisorySpec was not found while trying to analyse it -  
         autoloading is probably not configured properly.                                                            
 ------ ------------------------------------------------------------------------------------------------------------ 

 ------ ------------------------------------------------------------------------------------------------------------- 
  Line   spec/Parsers/SensioLabsSecurityCheckerParserSpec.php                                                         
 ------ ------------------------------------------------------------------------------------------------------------- 
         Class spec\Drupal\composer_security_checker\Parsers\SensioLabsSecurityCheckerParserSpec was not found while  
         trying to analyse it - autoloading is probably not configured properly.                                      
 ------ ------------------------------------------------------------------------------------------------------------- 

                                                                                                                        
 [ERROR] Found 3 errors
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Fixed

The above files are the only ones with errors, so I think this is ok.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Fixed » Needs review
StatusFileSize
new composer_security_checker-n3111074-7.patch422 bytes

No, no, forgot the info file.

joestewart’s picture

joestewart commented
Status: Needs review » Reviewed & tested by the community

RTBC.

No additional drupal-check results after the patch.

The module installs and functions correctly in D8 after the patch.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Reviewed & tested by the community » Postponed (maintainer needs more info) 
+++ b/composer_security_checker.info.yml
@@ -1,5 +1,5 @@
-core: 8.x

Why remove this? I've been just adding the new line on the other projects I help maintain.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Postponed (maintainer needs more info) » Fixed

Committed without that line removed, but let me know if it should be removed please.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.