I discovered a major UI issue with OG Subgroups today, reported by a Commons user on 2.3. Basically, the issue is that, if you disable "group" as a subgroup type, all "group" options are removed from the selection list when trying to add content to a group. The other co-maintainer of the module attempted to fix it, so the corresponding issue has been closed, but after reviewing that commit, it was actually causing more problems than it was solving. I just committed a fix to clear everything up. I recommend we up Commons to the latest.
This issue is most likely going unnoticed, because if you enable commons_subgroups - why would you disable subgroups for the "group" type. Makes no sense, but the bug condition is possible.
Comment | File | Size | Author |
---|---|---|---|
drupal_commons-update-latest-og-subgroups.patch | 741 bytes | mstef |
Comments
Comment #1
ezra-g CreditAttribution: ezra-g commentedGiven the nature of that fix and that the last OG_Subgroups release as in August, seems like it's time for a new release of that module which we can include in Commons.
Comment #2
japerryThis is old legacy Drupal 6.x-1.x-dev code and won't be supported. It is most likely not relevant and/or fixed in newer versions. Marking won't fix.
Comment #3
japerryChanging back to needs review. this is not 1.x its 2.x