Hi,

The total including taxes wasn't included in the amount sent to paypal.

I have attached the patch to fix the issue.

Thanks.

CommentFileSizeAuthor
tax.patch1.41 KBwebadpro
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Heine’s picture

This is only correct if the order contains 1 subscription with nothing else. This doesn't work well with the shopping cart atm.

instanceofjamie’s picture

@Heine - there's a bit of an issue around the number of items on an order, in that with Paypal WPS, the only item you can have on a subscription order is the subscription itself, since it's a different type of transaction entirely to regular cart orders. Previously I've coded around this by putting a separate front end on the module, however this isn't much use unless you're okay writing your own custom front ends for commerce.

This needs some thought, and might well knock on into a re-roll of the module entirely (which still needs doing, badly).

Any suggestions welcome :-)

instanceofjamie’s picture

@Heine - there's a bit of an issue around the number of items on an order, in that with Paypal WPS, the only item you can have on a subscription order is the subscription itself, since it's a different type of transaction entirely to regular cart orders. Previously I've coded around this by putting a separate front end on the module, however this isn't much use unless you're okay writing your own custom front ends for commerce.

This needs some thought, and might well knock on into a re-roll of the module entirely (which still needs doing, badly).

Any suggestions welcome :-)