See #3027924: Investigate Stripe regression on Commerce 2.12 for the gory details.

Stripe stores the api key as a static parameter of its own class, which isn't kept if the payment form is pulled from form cache, like with ajax calls. With the changes around inline forms coming in Commerce 2.12, this causes the payment to fail on a missing API key.

CommentFileSizeAuthor
#6 commerce_stripe-static_set_api_key-3030159-6.patch1.08 KBsmccabe
#3 interdiff_2-3.txt919 bytesknyshuk.vova
#3 commerce_stripe-static_set_api_key-3030159-3.patch3.11 KBknyshuk.vova
#2 commerce_stripe-static_set_api_key-3030159-2.patch3.25 KBsmccabe

Comments

smccabe created an issue. See original summary.

smccabe’s picture

smccabe commented
Status: Active » Needs review
StatusFileSize
new commerce_stripe-static_set_api_key-3030159-2.patch3.25 KB
knyshuk.vova’s picture

knyshuk.vova commented
Issue tags: +LutskGCW19
StatusFileSize
new commerce_stripe-static_set_api_key-3030159-3.patch3.11 KB
new interdiff_2-3.txt919 bytes

Fixed coding standards.
Added interdiff.

bojanz’s picture

bojanz commented

We could call init() from __construct() and __wakeup(), that way we wouldn't need to touch the public methods.

smccabe’s picture

smccabe commented
Status: Needs review » Needs work

I'll switch to __wakeup() that is way better, I wasn't aware that was a thing.

smccabe’s picture

smccabe commented
Status: Needs work » Needs review
StatusFileSize
new commerce_stripe-static_set_api_key-3030159-6.patch1.08 KB
bojanz’s picture

bojanz commented
Title: Fix support for form cache, needed for Commerce 2.12 compatability » Broken on Commerce 2.12
Priority: Normal » Critical

Closed the Commerce issue, created a change record: https://www.drupal.org/node/3031851

Let's proceed with this patch.

  • bojanz committed 7d55787 on 8.x-1.x authored by smccabe 
    Issue #3030159 by smccabe, knyshuk.vova, bojanz: Broken on Commerce 2.12
bojanz’s picture

bojanz commented
Status: Needs review » Fixed

Committed, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.