When downloading commerce_stripe + dependencies into a fresh Drupal installation via drush I received a message indicating that the PHP library was already present even though I had yet to download it:
commerce_price was enabled successfully. [ok]
commerce_stripe was enabled successfully. [ok]
commerce_ui was enabled successfully. [ok]
ctools was enabled successfully. [ok]
ctools defines the following permissions: use ctools import
libraries was enabled successfully. [ok]
Stripe PHP library already present. No download required. [ok]
I'm not at all familiar with the inner workings of drush, but looking at drush_commerce_stripe_download() it looks as if is_dir($path) would return TRUE if for some reason the libraries module didn't exist at the time this function is executed.
Looking forward to evaluating this module! Cheers -
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | Fix-stripe-php-library-installation-issue-2481643-6.patch | 1.3 KB | artreaktor |
Comments
Comment #2
aviindub commentedindeed you are correct. easy fix... thanks for the report.
Comment #3
aviindub commentedon another look, i realized there are a couple more issues. the drush command is not actually hooked up to its callback, and there is nothing to determine which version of the library is downloaded. this has never worked as far as i can tell.
Comment #4
aviindub commentedComment #5
aviindub commentedin the meantime, anyone wishing to install this module should download the library manually:
Download Stripe library v1.18.0 from GitHub and extract it to sites/all/libraries/stripe-php.
Comment #6
artreaktor commentedfew bugs fixed
Comment #9
aviindub commentedthanks for the patch. i went ahead and added a checkout to the current supported version so we can call this fixed.