I think we should switch to using EntityPublishedTrait

CommentFileSizeAuthor
#13 3194162---13.patch9.67 KBlukasss
#12 3194162--12.patch9.1 KBlukasss
#7 3194162--7.patch9.82 KBlukasss
#5 3194162--5.patch10.54 KBlukasss
#2 3194162--2.patch10.11 KBlukasss

Comments

lukasss created an issue. See original summary.

lukasss’s picture

lukasss commented
StatusFileSize
new 3194162--2.patch10.11 KB
lukasss’s picture

lukasss commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: 3194162--2.patch, failed testing. View results

lukasss’s picture

lukasss commented
Status: Needs work » Needs review
StatusFileSize
new 3194162--5.patch10.54 KB
lukasss’s picture

lukasss commented
Assigned: lukasss » Unassigned
lukasss’s picture

lukasss commented
StatusFileSize
new 3194162--7.patch9.82 KB

some fix

lukasss’s picture

lukasss commented
drugan’s picture

drugan commented
Status: Needs review » Reviewed & tested by the community

For me it works.

guy_schneerson’s picture

guy_schneerson commented

Thanks, @lukasss for the patch and @drugan for testing.
I will not have time to look at this today but in case it is not obvious can you give some more details about what issues your patch fixes. like what places we have duplicate code and what was removed.

lukasss’s picture

lukasss commented

The patch replaces the custom isActive() and so on methods with a more understandable and more commonly used EntityPublishedTrait.

lukasss’s picture

lukasss commented
StatusFileSize
new 3194162--12.patch9.1 KB

Update for last dev version

lukasss’s picture

lukasss commented
StatusFileSize
new 3194162---13.patch9.67 KB

You also need to do the update process