Currently, the live access token and token expiration data are stored in the module's config. This can be overwritten on config export, which is bad since this data is volatile and changes each month. Instead, it should be stored in Drupal's key/value state storage.

CommentFileSizeAuthor
#4 do_not_use_config_for-2919829-4.patch20.32 KBmglaman
#2 do_not_use_config_for-2919829-2.patch12.05 KBmglaman
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mglaman created an issue. See original summary.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman at Centarro commented
Status: Active » Needs review
FileSize
do_not_use_config_for-2919829-2.patch12.05 KB

Initial patch. However, some kind of service is needed to get application information from config and state. Otherwise, we'll get bugs later on.

Status: Needs review » Needs work

The last submitted patch, 2: do_not_use_config_for-2919829-2.patch, failed testing. View results

mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman at Centarro commented
Status: Needs work » Needs review
FileSize
do_not_use_config_for-2919829-4.patch20.32 KB

Adds Connect service to act as the application config.

  • mglaman committed d6c63bd on 8.x-1.x 
    Issue #2919829 by mglaman: Do not use config for live access token and...
mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman at Centarro commented
Status: Needs review » Fixed

Fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.