Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I've been using codesniffer on Commerce Shipping module. Found some errors. Fixed some. Welcome, reviewers.
Comment | File | Size | Author |
---|---|---|---|
#4 | fix_coding_standards-2755871-4.patch | 45.92 KB | Sardis |
#3 | fix_coding_standards-2755871-3.patch | 45.92 KB | Sardis |
Comments
Comment #2
Valentine94Hi Sardis.
Nice work, some small feedback:
File comment must be on a next line after @file.
Please fix the lines which exceeds the 80 characters on a line.
The same as the first point.
hook_update_N should contain only the text about what it usually do in PHPDoc.
Comment #3
Sardis CreditAttribution: Sardis at Drupal Ukraine Community for Drupal Ukraine Community commentedThanks for the feedback. Made changes according to it.
Comment #4
Sardis CreditAttribution: Sardis at Drupal Ukraine Community for Drupal Ukraine Community commentedSmall tabulation fixes on commerce_shipping_update_7003 and commerce_shipping_update_7004.
Comment #5
Valentine94Nice, RTBC
Comment #7
das-peter CreditAttribution: das-peter at Cando commentedNice! Will cause some re-rolls of other patches but now or never :P
Thanks.