Since mcrypt library is deprecated from PHP 7.1, module should be upgrade to work in php 7.2 and php 7.3

CommentFileSizeAuthor
#3 commerce_sermepa-3051258.patch2.09 KBfacine

Comments

jfuentes created an issue. See original summary.

pcambra’s picture

Patches are welcome! maybe this would help https://github.com/rectorphp/rector

facine’s picture

Status: Active » Needs review
StatusFileSize
new2.09 KB

This patch works with PHP >= 7.2 but I don't know it it works with PHP 5.6

pcambra’s picture

I'm not convinced about bumping up de PHP requirement for the Drupal 7 version, D7 still supports (but not recommends) PHP 5 https://www.drupal.org/docs/7/system-requirements/php-requirements#php_r..., maybe we should do this conditionally.

Upgrading the sermepa library to 1.0 is a completely different change I'd say.

CantButron’s picture

Hi guys,

The support for PHP 7.1 ends this year 2019 and I would ask you to give a little love to your version of Commerce Sermepa for Drupal 7, since it has not been updated for 4 years. There are still many who use Drupal 7 and I think it would be a good time to give this community a gift of Christmas.

Thanks in advance.

e0ipso’s picture

Hello CantButron.

Welcome to the Drupal community! This is one of the biggest open source communities in the world. I see that you registered to post this comment in https://www.drupal.org/user/3633321/track

I think there is a problem with your comment. It is demanding free work from the maintainers and imposing unfair social pressure on them to fulfill that free labour.

Since you are new, you may not know that you can contact them in their profile page (click on their names) to offer a paid contract to perform the maintenance duties that you need in your project. You even point out that many need this. That's great news, I'm sure you can coordinate to fund amazing maintenance and features while sharing costs.

I am not one of the maintainers of the module, nor I speak for them, but I suspect they are in alignment with my thoughts about free labour. After all you can't pay the electric bill with open source karma.

CantButron’s picture

Hi e0ipso,

The first of all is to say that I have not demanded anything at any time. I have simply asked for it and it is a big difference.

Second, as you can see, the plugin is offered for free, so I am not demanding they to work for me for free, I have simply asked kindly that if they can update what they created for free. In case they don't want or they can't, I understand and respect it.

And finally to say that it is not the first time that I help a web developer to correct some error without requiring anything in return. Not everyone does absolutely everything for money.

Anyway, I am sorry to have offended you so much with my cruel comment and I will keep it in mind so as not to hurt anyone's sensitivity in future comments.

Greetings

pcambra’s picture

Status: Needs review » Needs work

Patches are welcome so we do it in a way that don't drop PHP 7.1 and lower out of the ship.

pcambra’s picture

Status: Needs work » Closed (outdated)
Issue tags: -

D7 is EOL