Needs work
Project:
Commerce Return Merchandise Authorization
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
9 Mar 2015 at 12:49 UTC
Updated:
29 Jul 2015 at 06:08 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
id.tarzanych commentedComment #2
joelpittetIs there a case when this is false and the $order is not just empty itself?
Comment #3
id.tarzanych commented@joelpittet
Exactly. Commerce RMA module sends $order object without any parameters except one or two fields data
Comment #4
joelpittet@id.tarzanych can RMA just pass the $order along with it?
Comment #5
id.tarzanych commented@joelpittet
Well, it should do that.
But seems that we should wait till Commerce RMA developers change their code to make it compatible with Commerce Coupon 2.x/Commerce Discount or provide additional checks as I did in this patch.
Drupal 8 doesn't have such problem because we can easily check what Entity type object belongs to
Comment #6
joelpittetMoving over to Commerce Return Merchandise Authorization to deal with #4