Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
Drupal\commerce_pos_currency_denominations\Form;
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Comment | File | Size | Author |
---|---|---|---|
#12 | interdiff-2903635-10-12.txt | 3.33 KB | rakesh.gectcr |
#12 | 2903635-12.patch | 5.98 KB | rakesh.gectcr |
#10 | interdiff-2903635-6-10.txt | 596 bytes | rakesh.gectcr |
#10 | 2903635-10.patch | 4.55 KB | rakesh.gectcr |
#6 | Screen Shot 2017-08-25 at 11.53.06 PM.png | 59.34 KB | rakesh.gectcr |
Comments
Comment #2
rakesh.gectcrComment #3
rakesh.gectcr[Wed Aug 23 20:20:13.317053 2017] [php7:notice] [pid 12357] [client 127.0.0.1:51666] Uncaught PHP Exception Drupal\\Core\\Entity\\EntityMalformedException: "The entity does not have an ID." at /Users/rakeshjames/Sites/mystore/web/core/lib/Drupal/Core/Config/Entity/ConfigEntityStorage.php line 248, referer: http://mystore.lo/admin/commerce/config/currency_denominations/add
Comment #4
rakesh.gectcrAre we expecting
denominations
field with Add more Ajax button ?Comment #5
smccabe CreditAttribution: smccabe as a volunteer and at Acro Commerce commentedThat would probably make the most sense, although it could also just be a separate add form. The current d7 version just uses a very standard add/edit/delete setup, but it also isn't a config entity.
In short, whichever you feel is easier/better is fine with me.
Comment #6
rakesh.gectcrComment #7
rakesh.gectcrComment #8
rakesh.gectcrComment #9
rakesh.gectcrneed to add the changes from CurrencyDenominations file as well
Comment #10
rakesh.gectcrComment #11
swickham CreditAttribution: swickham at Acro Commerce commentedHere's what I could find that I think need work:
Comment #12
rakesh.gectcr@swickham Thank you, for the review.
I have done all the points which you mentioned above except
We will work on this after the alpha release.
I have created a separated issue as a child of this So that we will not miss it.
#2906918: The "Remove one" button makes it difficult to manage denominations in the form
Comment #13
swickham CreditAttribution: swickham at Acro Commerce commentedLooks good.
Comment #15
smccabe CreditAttribution: smccabe as a volunteer and at Acro Commerce commented