hi,
if I use Commerce Customizable Products Module (https://www.drupal.org/project/commerce_custom_product)
the item count can not increase as well as the shopping cart hover

while the original shopping cart block has no problem

see the screenshot

thanks

CommentFileSizeAuthor
#16 commerce_popup_cart-settings-for-line-item-types-2745469-16-7.x.patch2.48 KBpontus.froden
#15 cart_with_giftcard.png60.74 KBpontus.froden
#3 commerce_popup_cart-not_compatible_with_commerce_customizable_products_module-2745469-2.patch639 bytesmanish.shah
custom.png30.75 KBrei

Comments

rei created an issue. See original summary.

rei’s picture

rei commented
Issue summary: View changes
manish.shah’s picture

manish.shah commented
Assigned: Unassigned » manish.shah
Status: Active » Needs review
StatusFileSize
new commerce_popup_cart-not_compatible_with_commerce_customizable_products_module-2745469-2.patch639 bytes

Hi Rei,

I have fixed the issue and attached patch for same. Kindly review and let me know if you find anything.

-Manish

rei’s picture

rei commented

Hi, the patch #3 fix this problem
thank you for fast response

manish.shah’s picture

manish.shah commented
Status: Needs review » Fixed

3cwebdev’s picture

3cwebdev commented

Committed to dev.

rei’s picture

rei commented
Status: Fixed » Needs review

hi, this is also has not commited to the dev

3cwebdev’s picture

3cwebdev commented

Committed to DEV.

pontus.froden’s picture

pontus.froden commented

Thanks this patch also solves the problem with selling giftcards through commerce_gc. The popup cart said the shopping card was empty when there only was a giftcard in the basket.

Haven't found any issues with it yet.

pontus.froden’s picture

pontus.froden commented

Just discovered one error with this. If you apply a coupon to the cart then it will include that line when it show number of products in cart.

If you have 2 items in cart and go to checkout and add a coupon the popup will say it is 3 items in cart.

Will fix a patch as soon as I have the time.

3cwebdev’s picture

3cwebdev commented

@pontus.froding - I just tested this on a live install with the latest version of this module and the item count works correctly for me. I added an item to the cart and the cart pop showed a count of 1 item. I then added a coupon and the the count stayed at 1. Can you provide the exact steps to reproduce the issue?

pontus.froden’s picture

pontus.froden commented

Maybe it is because my coupon is a giftcard from commerce_gc? Forgot to say that before.

Haven't looked into it anymore yet but the issue happens if I go to checkout, add the giftcard and then either refresh the checkout page or go to another page for some more shopping ...

I would say it's not a big issue, most of the customers would probably not refresh the checkout page or do some more shopping after they have added a giftcard.

pontus.froden’s picture

pontus.froden commented
StatusFileSize
new cart_with_giftcard.png60.74 KB

Here is a printscreen of the cart

pontus.froden’s picture

pontus.froden commented
StatusFileSize
new commerce_popup_cart-settings-for-line-item-types-2745469-16-7.x.patch2.48 KB

Here is the patch.

First I was thinking about just adding the line item type "giftcard_use" and "product_discount" in a list to exclude but then we would have the problem again if someone adds another line item type. So I made a setting for it in admin config.

Product is choosen by default, if you need to include another one then you just choose it in the Popup Cart Config.

3cwebdev’s picture

3cwebdev commented

Patch committed to dev.

3cwebdev’s picture

3cwebdev commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.