Needs work
Project:
Commerce Maksuturva
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
12 Sep 2012 at 12:39 UTC
Updated:
17 Sep 2012 at 18:33 UTC
According to meeting with Maksuturva today. It's quite common that you might get pmtq_returncode as 00 for cases where consumer is in bank and haven't returned back yet.
That means that we shouldn't remove scheduled job for payment status check when getting pmtq_returncode as value 00.
Comments
Comment #1
juhaniemi commentedI can confirm this and run into this problem on a site using this module (I temporarily commented out the job removing)
Should we remove the removing of job_scheduler entirely, or set some expiry timestamp, and after expiration the job scheduler is removed?
Comment #2
imiksuTo deal with this, we could have an evaluation that if the job has been created more than 30mins ago, it can be removed. Otherwise just wait for next run.
Comment #3
imiksuAnd maybe an extra check for how many times is was previously failed?
Maybe something like:
And add extra condition on
failed_countwhen doing conditional$transactionsave.Comment #4
juhaniemi commentedLooks good. A tested patch welcome. :-)