Needs review
Project:
Commerce Login Step
Version:
7.x-1.x-dev
Component:
Code
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
18 Nov 2014 at 12:20 UTC
Updated:
1 Nov 2015 at 21:14 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
vasikethere is a patch the implements the solution proposal from the issue description.
to achieve the issue i had to change the wrapper used for the ajax - entire checkout form to include also the buttons.
Comment #2
cornelia commentedwhy not simply setting the radios as required in function commerce_login_step_form_commerce_checkout_form_alter() like so
...
'#options' => array(
'anonymous' => t('Continue without login'),
'login' => t('Login with an existing account'),
),
'#required' => TRUE,
...
Comment #3
krisahil commentedWe've been using this module and see the same problem. However, I'd like to propose to fix it by using the existing "Continue" button, instead of disabling it. I think this is a cleaner approach. Let me know what you think!
Comment #4
ultrandy89 commentedI am finding in my site I am able to have an anonymous order with an existing email. Nothing seems to prevent this from happening. Is there even a quick rule I could put in?
To clarify:
Comment #5
anybodyThe suggestion from #2 is good and works wonderful! Please add this as a quickfix release!
The patch from #3 changes several things so that we should have a deeper look.
Is there still an active maintainer for this module willing to fix the bugs? I'd like to offer my help in maintainership if you're no more active.
PS: If we'd like to disable the process button, the Drupal form #states API will help, I think!
Comment #6
mglamanThis does not prevent a user from skipping the selection of "Choose how you want to checkout"
Comment #7
mglamanThis addresses item #1 in summary, which other patch only concerned #2. Looks like we should be solid on fix now for original issue summary.
Comment #8
nebel54#prefix is used in both lines, and it raises notices, if $form['#prefix'] is not defined.
I needed to remove this code-style improvement, to apply another patch (2362777-9)
Added an improved version of patch #7
Comment #9
nebel54Those patches went horribly wrong :( Re-Uploaded them.